Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293090: Remove unused par_oop_since_save_marks_iterate_done #10078

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 30, 2022

Trivial change of removing dead code.

Test: build


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293090: Remove unused par_oop_since_save_marks_iterate_done

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10078/head:pull/10078
$ git checkout pull/10078

Update a local copy of the PR:
$ git checkout pull/10078
$ git pull https://git.openjdk.org/jdk pull/10078/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10078

View PR using the GUI difftool:
$ git pr show -t 10078

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10078.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8293090 8293090: Remove unused par_oop_since_save_marks_iterate_done Aug 30, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293090: Remove unused par_oop_since_save_marks_iterate_done

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 30, 2022
@kimbarrett
Copy link

Oops, and yes, trivial.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

Going to push as commit 622be79.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3d0ab2b: 8292858: G1: Remove redundant check in G1FlushHumongousCandidateRemSets
  • 6e24827: 8292878: x86: Make scratch register usage explicit in assembler code
  • f5ebbf3: 8292657: Calling GetLocalXXX from virtual thread with thread parameter set to NULL returns carrier locals
  • 550e5d7: 4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for
  • d3d2e66: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols
  • f3ebb42: 8293036: x86_64: Move Continuation-related stub methods to MacroAssembler
  • 1576f99: 8288759: GCC 12 fails to compile signature.cpp due to -Wstringop-overread
  • f285cea: 8293037: Remove DebuggerBase.writeBytes() and related code from SA
  • 343333a: 8293004: (fs) FileChannel.transferXXX use of copy_file_range needs fallback handling for ENOSYS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2022
@openjdk openjdk bot closed this Aug 30, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 30, 2022
@albertnetymk albertnetymk deleted the trivial branch August 30, 2022 19:37
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@albertnetymk Pushed as commit 622be79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants