-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8175382: clhsdb pmap should print the end addresses of the load modules #10087
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks,
Serguei
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks Seguei and Yasumasa! /integrate |
Going to push as commit 07616de.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit 07616de. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The clhsdb 'pmap' command prints the start addresses and the sizes of the various load modules. It would be more intuitive to have the end address printed as the VM.dynlibs jcmd does.
Before:
0x00007f8839c38000 5920K /usr/lib64/libc-2.17.so
0x00007f883a006000 4072K /usr/lib64/libdl-2.17.so
0x00007f883a20a000 4056K /usr/lib64/libpthread-2.17.so
0x00007f883a426000 3944K /usr/lib64/libz.so.1.2.7
After:
0x7f0f8e482000-0x7f0f8ea00000 5624K /usr/lib64/libc-2.17.so
0x7f0f8e850000-0x7f0f8ec00000 3776K /usr/lib64/libdl-2.17.so
0x7f0f8ea54000-0x7f0f8ee00000 3760K /usr/lib64/libpthread-2.17.so
0x7f0f8ec70000-0x7f0f8f000000 3648K /usr/lib64/libz.so.1.2.7
Note that VM.dynlibs doesn't use the 0x prefix. I considered doing the same for pmap, but it did cause one test failure that was searching for the address starting with 0x, so I decided to leave it in. Notice I also dropped the leading 0's to keep things a big more compact (VM.dynlibs does the same).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10087/head:pull/10087
$ git checkout pull/10087
Update a local copy of the PR:
$ git checkout pull/10087
$ git pull https://git.openjdk.org/jdk pull/10087/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10087
View PR using the GUI difftool:
$ git pr show -t 10087
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10087.diff