Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8175382: clhsdb pmap should print the end addresses of the load modules #10087

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Aug 30, 2022

The clhsdb 'pmap' command prints the start addresses and the sizes of the various load modules. It would be more intuitive to have the end address printed as the VM.dynlibs jcmd does.

Before:

0x00007f8839c38000 5920K /usr/lib64/libc-2.17.so
0x00007f883a006000 4072K /usr/lib64/libdl-2.17.so
0x00007f883a20a000 4056K /usr/lib64/libpthread-2.17.so
0x00007f883a426000 3944K /usr/lib64/libz.so.1.2.7

After:

0x7f0f8e482000-0x7f0f8ea00000 5624K /usr/lib64/libc-2.17.so
0x7f0f8e850000-0x7f0f8ec00000 3776K /usr/lib64/libdl-2.17.so
0x7f0f8ea54000-0x7f0f8ee00000 3760K /usr/lib64/libpthread-2.17.so
0x7f0f8ec70000-0x7f0f8f000000 3648K /usr/lib64/libz.so.1.2.7

Note that VM.dynlibs doesn't use the 0x prefix. I considered doing the same for pmap, but it did cause one test failure that was searching for the address starting with 0x, so I decided to leave it in. Notice I also dropped the leading 0's to keep things a big more compact (VM.dynlibs does the same).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8175382: clhsdb pmap should print the end addresses of the load modules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10087/head:pull/10087
$ git checkout pull/10087

Update a local copy of the PR:
$ git checkout pull/10087
$ git pull https://git.openjdk.org/jdk pull/10087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10087

View PR using the GUI difftool:
$ git pr show -t 10087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8175382 8175382: clhsdb pmap should print the end addresses of the load modules Aug 30, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8175382: clhsdb pmap should print the end addresses of the load modules

Reviewed-by: sspitsyn, ysuenaga

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 17283cf: 8293011: riscv: Duplicated stubs to interpreter for static calls
  • 6076128: 8292008: Transition the JDK to the common standard of C11
  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file
  • dd54153: 8293162: Drop support for VS2017
  • 12317ef: 8293046: Move CDS command-line flags to cds_globals.hpp
  • 372fc58: 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java
  • 3c1bda4: 8293019: [JVMCI] change ratio of libgraal to C1 threads and use one isolate per libgraal thread
  • 0d51f63: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation
  • 5d6779f: 8292681: Add JMH for ProtectionDomain
  • 38e6706: 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler
  • ... and 8 more: https://git.openjdk.org/jdk/compare/1cf245d77c0948b6f03025e80faa4517a6f79f3f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2022
Copy link
Member

@YaSuenag YaSuenag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@plummercj
Copy link
Contributor Author

Thanks Seguei and Yasumasa!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit 07616de.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 9444a08: 8290709: Incorrect dominance error for unconditional pattern vs. null
  • 6a1b0b5: 8293154: TemporalQueries java doc error
  • 5204528: 8293201: Library detection in runtime/ErrorHandling/TestDwarf.java fails on some systems
  • 2d10d4f: 8291651: CleanerTest.java fails with "Cleanable was cleaned"
  • bd674dc: 8293163: G1: Rename G1HeapRegionAttr::is_humongous
  • 479795b: 8293164: Remove unimplemented Generation::print_heap_change
  • 6e6202c: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 17283cf: 8293011: riscv: Duplicated stubs to interpreter for static calls
  • 6076128: 8292008: Transition the JDK to the common standard of C11
  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file
  • ... and 15 more: https://git.openjdk.org/jdk/compare/1cf245d77c0948b6f03025e80faa4517a6f79f3f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@plummercj Pushed as commit 07616de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8175382_pmap branch October 11, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants