8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking

[sspitsyn]

The problem is that the following assert in the JvmtiExport::post_object_free is wrong:
assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE), "checking");

Even though the condition was checked before, it can be changed later as it is racy by JVM TI design.
It has to be replaced with the check:

  if (!env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) {
    return; // the event type has been already disabled
  }

In progress: mach5 nsk.jvmti and nsk.jdi test runs.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10109/head:pull/10109
$ git checkout pull/10109

Update a local copy of the PR:
$ git checkout pull/10109
$ git pull https://git.openjdk.org/jdk pull/10109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10109

View PR using the GUI difftool:
$ git pr show -t 10109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10109.diff

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2e749103)

[zhengyu123]

Looks good.

[sspitsyn]

Chris, Zhengyu and Leonid, thank you for review!

[openjdk]

@sspitsyn This pull request has not yet been marked as ready for integration.

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking

Reviewed-by: cjplummer, zgu, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• e393973: 8292990: Improve test coverage for XPath Axes: parent
• fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
• 04d8069: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
• 3d254d3: 8289510: Improve test coverage for XPath Axes: namespace
• 2d18dda: 8173605: Remove support for source and target 1.7 option in javac
• 7c2f299: 8293202: Document how to edit doc/testing, doc/building
• 07616de: 8175382: clhsdb pmap should print the end addresses of the load modules
• ... and 11 more: https://git.openjdk.org/jdk/compare/12317ef7d001f5a29c731238dc06ccfd0c97f1e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 99c3ab0.
Since your change was applied there have been 21 commits pushed to the master branch:

• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• e393973: 8292990: Improve test coverage for XPath Axes: parent
• fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
• 04d8069: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
• 3d254d3: 8289510: Improve test coverage for XPath Axes: namespace
• 2d18dda: 8173605: Remove support for source and target 1.7 option in javac
• 7c2f299: 8293202: Document how to edit doc/testing, doc/building
• 07616de: 8175382: clhsdb pmap should print the end addresses of the load modules
• ... and 11 more: https://git.openjdk.org/jdk/compare/12317ef7d001f5a29c731238dc06ccfd0c97f1e6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 99c3ab0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.