-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293288: bootcycle build failure after JDK-8173605 #10135
Conversation
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks @erikj79 for the review. |
Thanks @jddarcy . |
@DamonFool Warning! Your commit did not result in any changes! No push attempt will be made. |
Already fixed in #10148 , so close this one. |
Hi all,
bootcycle fails to build after JDK-8173605 due to the following two warnings
To suppress warnings about obsolete options,
-Xlint:-options
is added.Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10135/head:pull/10135
$ git checkout pull/10135
Update a local copy of the PR:
$ git checkout pull/10135
$ git pull https://git.openjdk.org/jdk pull/10135/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10135
View PR using the GUI difftool:
$ git pr show -t 10135
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10135.diff