8293290: RISC-V: Explicitly pass a third temp register to MacroAssembler::store_heap_oop

[RealFYang]

Currently G1 (and Shenandoah) implicitly uses x13 in oop_store_at on riscv.

This out of the blue register fixed for x86 in JDK-8283186.
This would be fixed in the same way on riscv by passing the temporary register explicitly so it is part of the GC API.

Testing: Passed Tier1 test on linux-riscv64 SiFive Unmatched board.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293290: RISC-V: Explicitly pass a third temp register to MacroAssembler::store_heap_oop

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10137/head:pull/10137
$ git checkout pull/10137

Update a local copy of the PR:
$ git checkout pull/10137
$ git pull https://git.openjdk.org/jdk pull/10137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10137

View PR using the GUI difftool:
$ git pr show -t 10137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10137.diff

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1a70d8cb)

[shipilev]

Looks fine.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293290: RISC-V: Explicitly pass a third temp register to MacroAssembler::store_heap_oop

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• ce06a3b: 8293023: Change CardTable::is_in_young signature
• 26cac08: 8293209: Parallel: Remove unused variables in PSParallelCompact::invoke
• 46523b8: 8293219: Microsoft toolchain selection picks 32-bit tools over 64-bit
• bc5ffc8: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
• 98ce45f: 8292981: Unify and restructure integer printing format specifiers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

@shipilev : Thanks for the review. Also passed Tier2 test. Integrate then.
/integrate

[openjdk]

Going to push as commit 5bed9f7.
Since your change was applied there have been 26 commits pushed to the master branch:

• 48b3ab0: 8293167: Memory leak in JfrThreadSampler if stackdepth is larger than default (64)
• 4067321: 8291586: Broken links in JVMTI specification
• 32f4dc8: 8293295: Add type check asserts to java_lang_ref_Reference accessors
• e945619: 8293088: Fix compilation with the new Visual Studio preprocessor
• 730ced9: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly
• 3464019: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
• e92b9e4: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling
• 767262e: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr"
• a366e82: 7113208: Incorrect javadoc on java.net.DatagramPacket.setLength()
• ac05bc8: 8293293: Move archive heap loading code out of heapShared.cpp
• ... and 16 more: https://git.openjdk.org/jdk/compare/3ac91b08cbe16bc1a347178f853513f930ffeaf3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit 5bed9f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.