8293315: Add back logging for Placeholders#10145
8293315: Add back logging for Placeholders#10145coleenp wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
|
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review, Ioi. |
|
Going to push as commit 83a3408.
Your commit was automatically rebased without conflicts. |
I lost some information in the logging code for PlaceholderTable that I really want when I converted it to use a ResourceHashtable, so this minor patch adds it back.
Tested locally with -Xlog:class+load+placeholders=trace, and tier1.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10145/head:pull/10145$ git checkout pull/10145Update a local copy of the PR:
$ git checkout pull/10145$ git pull https://git.openjdk.org/jdk pull/10145/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10145View PR using the GUI difftool:
$ git pr show -t 10145Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10145.diff