Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8293288: bootcycle build failure after JDK-8173605 #10148

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Sep 2, 2022

In order to get the build-breakage fixed sooner, I'm re-sending out @DamonFool 's fix #10135 under this PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293288: bootcycle build failure after JDK-8173605

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10148/head:pull/10148
$ git checkout pull/10148

Update a local copy of the PR:
$ git checkout pull/10148
$ git pull https://git.openjdk.org/jdk pull/10148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10148

View PR using the GUI difftool:
$ git pr show -t 10148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10148.diff

@jddarcy
Copy link
Member Author

jddarcy commented Sep 2, 2022

/contributor @DamonFool

@jddarcy
Copy link
Member Author

jddarcy commented Sep 2, 2022

Thanks @DamonFool for developing the fix!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293288: bootcycle build failure after JDK-8173605

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@jddarcy Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 2, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2022

Webrevs

@jddarcy
Copy link
Member Author

jddarcy commented Sep 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

Going to push as commit b6477fd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2022
@openjdk openjdk bot closed this Sep 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@jddarcy Pushed as commit b6477fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy
Copy link
Member Author

jddarcy commented Sep 2, 2022

PS @DamonFool, sorry the contributor command I issued didn't have the effect of crediting you; I should have checked the command status more closely before pushing. Thanks again for the fix.

@DamonFool
Copy link
Member

Okay, never mind.
I would push the build-breakage fix sooner next time.

@jddarcy jddarcy deleted the JDK-8293288 branch June 10, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants