-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8293288: bootcycle build failure after JDK-8173605 #10148
Conversation
/contributor @DamonFool |
Thanks @DamonFool for developing the fix! |
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@jddarcy Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/integrate |
Going to push as commit b6477fd. |
PS @DamonFool, sorry the contributor command I issued didn't have the effect of crediting you; I should have checked the command status more closely before pushing. Thanks again for the fix. |
Okay, never mind. |
In order to get the build-breakage fixed sooner, I'm re-sending out @DamonFool 's fix #10135 under this PR.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10148/head:pull/10148
$ git checkout pull/10148
Update a local copy of the PR:
$ git checkout pull/10148
$ git pull https://git.openjdk.org/jdk pull/10148/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10148
View PR using the GUI difftool:
$ git pr show -t 10148
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10148.diff