Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8290011: IGV: Upgrade to Netbeans Platform 14 and remove dead code #10164

Closed
wants to merge 30 commits into from

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Sep 5, 2022

Upgrade IGV to the newest Netbeans Platform 14 which was released on June 9 2022 (officially support running on JDK 11 and JDK 17).

Testing

Tested the following use cases manually on macOS and JDK 17:

  • build with maven 3.8.1
  • import graphs via network (localhost)
  • Save all groups to XML
  • Save selected groups to XML
  • Remove selected graphs
  • Remove selected groups
  • Remove all groups
  • Open XML graph file
  • Expand groups in Outline
  • Open a graphs in from same and different group in Outline
  • "Open clone" in the Outline
  • "Open Difference to current graph" for graphs in same and different group in Outline
  • Opening a new graph : Updates the Bytecode and Control Flow window
  • Show next / previous graph in current group buttons
  • Expand / Reduce the difference selection buttons
  • Changing of the difference selection by modifying the slider
  • Extract set of selected nodes and check if they are centered
  • Hiding of selected nodes
  • Showing all nodes again
  • Zooming in / out
  • Different views: Sea of nodes / clustered seas of nodes / CFG
  • Satellite view: button and by pressing the S key
  • Enable / Disable "Show neighbouring nodes of fully visible nodes semi-transparent"
  • Undo / Redo
  • Selection mode: button and by holding Ctrl + mouse-drag
  • Searching a node: Selects the node and centres it. Makes the node visible if it is hidden
  • Searching a block: Selects all nodes in the block and centres it. Makes the all the nodes in the block visible
  • Selecting node(s): adjusts colours in slider. Show property in Properties window
  • Hovering a node: highlights node and shows property box
  • Hovering a connection: highlights connection and corresponding nodes
  • apply filters
  • select nodes corresponding to a bytecode
  • select nodes corresponding to a basic block in the control flow

Minor Fixes

  • Fixed that Bytecode Component and Control Flow Component gets updated immediately when opening a new graph
  • Fixed warning about missing position attribute of menu items

Refactoring

  • removed lots of unused or redundant code

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290011: IGV: Upgrade to Netbeans Platform 14 and remove dead code

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10164/head:pull/10164
$ git checkout pull/10164

Update a local copy of the PR:
$ git checkout pull/10164
$ git pull https://git.openjdk.org/jdk pull/10164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10164

View PR using the GUI difftool:
$ git pr show -t 10164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10164.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2022

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2022

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 5, 2022
@tobiasholenstein tobiasholenstein marked this pull request as ready for review September 5, 2022 13:03
Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the major cleanup! For ease of reviewing and testing, I think it would be better, if possible, to split this changeset into three PRs: one for the minor fixes, one for the cleanup, and one for the platform update. Regarding the last one, NetBeans 15 was just announced (released on August 31, 2022), so perhaps you could update directly to that version.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2022
@tobiasholenstein
Copy link
Contributor Author

Thanks for the major cleanup! For ease of reviewing and testing, I think it would be better, if possible, to split this changeset into three PRs: one for the minor fixes, one for the cleanup, and one for the platform update. Regarding the last one, NetBeans 15 was just announced (released on August 31, 2022), so perhaps you could update directly to that version.

Thanks @robcasloz for your comment! I agree with your suggestion. I will close this PR and open 3 new ones: for for the refactoring, one for the bug fixes, and one for the upgrade to NetBeans 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
2 participants