Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler #10167

Closed
wants to merge 3 commits into from
Closed

6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler #10167

wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 5, 2022 •
edited by openjdk bot
Loading

NPE is thrown for closed/disposed JDialogs after uninstalling the UI which is because for SynthEditorPaneUI even though is disposed of, Nimbus propertyHandler tries to get the style of this disposed component resulting in NPE,
which is fixed by a null check to prevent deferencing style object to get the color.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10167/head:pull/10167
$ git checkout pull/10167

Update a local copy of the PR:
$ git checkout pull/10167
$ git pull https://git.openjdk.org/jdk pull/10167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10167

View PR using the GUI difftool:
$ git pr show -t 10167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler Sep 5, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 5, 2022
@openjdk
Copy link

openjdk bot commented Sep 5, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 5, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2022 •
edited
Loading

Webrevs

mrserb
mrserb reviewed Sep 6, 2022
View reviewed changes
test/jdk/javax/swing/plaf/synth/RepaintNPE.java Outdated

try
{
Method method = jComp.getClass().getMethod ( "getUI" );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getUI() method is public, can be used directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. modified.

@openjdk
Copy link

openjdk bot commented Sep 8, 2022 •
edited
Loading

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler

Reviewed-by: serb, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
  • 37df5f5: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 699c429: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
  • 005b49b: 8293044: C1: Missing access check on non-accessible class
  • 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
  • 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • dbec22b: 8293287: add ReplayReduce flag
  • b8598b0: 8291660: Grapheme support in BreakIterator
  • a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
  • ... and 110 more: https://git.openjdk.org/jdk/compare/bd674dc55e87940f442cb140841f95424b6d42fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2022
DamonGuy
DamonGuy approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes and NPE is no longer. Looks good to me

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

Going to push as commit 4c77bd3.
Since your change was applied there have been 120 commits pushed to the master branch:

  • d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
  • 37df5f5: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 699c429: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
  • 005b49b: 8293044: C1: Missing access check on non-accessible class
  • 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
  • 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • dbec22b: 8293287: add ReplayReduce flag
  • b8598b0: 8291660: Grapheme support in BreakIterator
  • a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
  • ... and 110 more: https://git.openjdk.org/jdk/compare/bd674dc55e87940f442cb140841f95424b6d42fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2022
@openjdk openjdk bot closed this Sep 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@prsadhuk Pushed as commit 4c77bd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-6529151 branch September 12, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrserb mrserb mrserb approved these changes

@DamonGuy DamonGuy DamonGuy approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prsadhuk @mrserb @DamonGuy