8293403: JfrResolution::on_jvmci_resolution crashes when caller is null

[dougxc]

When the caller argument to JfrResolution::on_jvmci_resolution is null, the method should raise an IllegalAccessError instead of crashing with a SIGSEGV.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293403: JfrResolution::on_jvmci_resolution crashes when caller is null

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10180/head:pull/10180
$ git checkout pull/10180

Update a local copy of the PR:
$ git checkout pull/10180
$ git pull https://git.openjdk.org/jdk pull/10180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10180

View PR using the GUI difftool:
$ git pr show -t 10180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10180.diff

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (63fc056d)

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293403: JfrResolution::on_jvmci_resolution crashes when caller is null

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• c05015b: 8291736: find_method_handle_intrinsic leaks Method*
• b2067e6: 8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail
• 6a1e98c: 8293213: G1: Remove redundant assertion in G1RemSet::clean_card_before_refine
• a92c1ff: 8287912: GTK L&F : Background of tree icons are red
• 272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
• 26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
• 8e22f2b: 8293361: GHA: dump config.log in case of configure failure
• b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
• 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
• 4955835: 8282434: Leading combining diacritic character in string renders incorrectly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

/integrate

[openjdk]

Going to push as commit 7c96608.
Since your change was applied there have been 10 commits pushed to the master branch:

• c05015b: 8291736: find_method_handle_intrinsic leaks Method*
• b2067e6: 8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail
• 6a1e98c: 8293213: G1: Remove redundant assertion in G1RemSet::clean_card_before_refine
• a92c1ff: 8287912: GTK L&F : Background of tree icons are red
• 272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
• 26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
• 8e22f2b: 8293361: GHA: dump config.log in case of configure failure
• b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
• 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
• 4955835: 8282434: Leading combining diacritic character in string renders incorrectly

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 7c96608.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.