8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "

[plummercj]

Each time you attach to a target JVM on Windows, thread Id's can change (although they rarely do). For this reason you can't reliably do what this test is doing, which is attach, run jstack to get the threadId of a thread, detach, attach again and run the thread command using the threadId. It might not be valid any more. For this reason I am changing the test to ignore the result of the thread command when running on windows. This is the same fix as was done for JDK-8280770

I'd like to push this as a trivial change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "

Reviewers

• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10185/head:pull/10185
$ git checkout pull/10185

Update a local copy of the PR:
$ git checkout pull/10185
$ git pull https://git.openjdk.org/jdk pull/10185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10185

View PR using the GUI difftool:
$ git pr show -t 10185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10185.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3f13b203)

[alexmenkov]

I agree that this may be considered as a trivial change

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "

Reviewed-by: amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• aff9a69: 8283224: Remove THREAD_NOT_ALIVE from possible JDWP error codes
• 76df73b: 8293456: runtime/os/TestTracePageSizes.java sub-tests fail with "AssertionError: No memory range found for address: NNNN"
• 32c7b62: 8293146: Strict DateTimeFormatter fails to report an invalid week 53
• 02dce24: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
• d36abbe: 8293496: ProblemList runtime/os/TestTracePageSizes.java on linux-x64
• 1ee59ad: 8289798: Update to use jtreg 7
• 5934669: 8292383: Create a SymbolHandle type to use for ResourceHashtable
• 6ff4775: 8285487: AArch64: Do not generate unneeded trampolines for runtime calls
• d696104: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.
• 14fd1b6: 8292921: Rewrite object field printer
• ... and 8 more: https://git.openjdk.org/jdk/compare/85d4b49151e9529051f1ed344749a487d3e92165...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks Alex!

/integrate

[openjdk]

Going to push as commit 51de765.
Since your change was applied there have been 21 commits pushed to the master branch:

• 8a48965: 8293514: ProblemList gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 on all platforms
• 1e031e6: 8293232: Fix race condition in pkcs11 SessionManager
• 1080c4e: 8293508: ProblemList gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64
• aff9a69: 8283224: Remove THREAD_NOT_ALIVE from possible JDWP error codes
• 76df73b: 8293456: runtime/os/TestTracePageSizes.java sub-tests fail with "AssertionError: No memory range found for address: NNNN"
• 32c7b62: 8293146: Strict DateTimeFormatter fails to report an invalid week 53
• 02dce24: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
• d36abbe: 8293496: ProblemList runtime/os/TestTracePageSizes.java on linux-x64
• 1ee59ad: 8289798: Update to use jtreg 7
• 5934669: 8292383: Create a SymbolHandle type to use for ResourceHashtable
• ... and 11 more: https://git.openjdk.org/jdk/compare/85d4b49151e9529051f1ed344749a487d3e92165...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 51de765.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.