Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293445: clhsdb "thread" command gives incorrect error message for bad threadID #10186

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Sep 6, 2022

As pointed out in JDK-8283010, when a bad threadID is passed to the clhsdb "thread" command, the error message is incorrect:

hsdb> thread 18
Couldn't find thread thread

It should say "thread 18", not "thread thread". The code looks like:

                    out.println("Couldn't find thread " + name);

"name" is the name of the command. It should instead use "id".

I'd like to push this as a trivial change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293445: clhsdb "thread" command gives incorrect error message for bad threadID

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10186/head:pull/10186
$ git checkout pull/10186

Update a local copy of the PR:
$ git checkout pull/10186
$ git pull https://git.openjdk.org/jdk pull/10186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10186

View PR using the GUI difftool:
$ git pr show -t 10186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10186.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8293445 8293445: clhsdb "thread" command gives incorrect error message for bad threadID Sep 6, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2022
@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 6, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. I agree that this is a trivial fix.

@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293445: clhsdb "thread" command gives incorrect error message for bad threadID

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • da59618: 8264744: (fs) Use file cloning in Linux version of Files::copy method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2022
@plummercj
Copy link
Contributor Author

Thanks, Dan!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 6, 2022

Going to push as commit 710a143.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 57930f8: 8293285: x86_64: Move libm stub implementations to StubGenerator
  • 5b4c415: 8293254: x86_64: Extract arraycopy stub implementations into a separate file
  • fb6eb6f: 8293245: x86_64: Extract Adler32 stub implementation into stubGenerator_x86_64_adler.cpp
  • da59618: 8264744: (fs) Use file cloning in Linux version of Files::copy method

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2022
@openjdk openjdk bot closed this Sep 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 6, 2022
@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@plummercj Pushed as commit 710a143.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8293445_bad_threadid branch October 11, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants