New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8172366: Support SHA-3 based signatures #102
Conversation
Enhance default JDK providers except SunPKCS11 with signatures using SHA-3 family of digests
👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into |
@valeriepeng The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
/issue add 8172366 |
@valeriepeng This issue is referenced in the PR title - it will now be updated. |
/csr needed |
@valeriepeng this pull request will not be integrated until the CSR request JDK-8252260 for issue JDK-8172366 has been approved. |
Webrevs
|
/label remove core-libs |
@valeriepeng |
Do you want to list the "inP1363Format" SHA3 algorithms in the "Java Security Standard Algorithm Names" documentation in this CSR? |
src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java
Outdated
Show resolved
Hide resolved
Yes, I will do that. Thanks~ |
Amended class javadoc with P1363 support and added javadoc for the new static classes.
Updated the KnownOIDs lookup code inside validateSigParams to check for unsupported digest algorithms. Changed checkKeyLength() to throw InvalidKeyException instead of SignatureException and adjusted caller code accordingly.
Removed the trailing white spaces in previous update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me,
@valeriepeng This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 193 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new constants in MGF1ParameterSpec.java should have "@SInCE 16".
/summary Enhance default JDK providers including SUN, SunRsaSign, and SunEC, with signatures using SHA-3 family of digests. |
@valeriepeng Setting summary to |
Added "@SInCE 16" to the new SHA-3 constants.
/integrate |
@valeriepeng Since your change was applied there have been 193 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4020682. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Yes, made the change in last commit. |
Merge jdk-22+0 into rivos/main
Could someone please help review this RFE?
Enhance default JDK providers except SunPKCS11 with signatures using SHA-3 family of digests. SunPKCS11 provider will be updated separately (JDK-8242332).
This changes covers SUN, SunRsaSign, and SunEC providers. Changes are straightforward, just add SHA-3 digests to various signature algorithms.
Please review the corresponding CSR as well. It's at: https://bugs.openjdk.java.net/browse/JDK-8252260
Thanks!
Valerie
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/102/head:pull/102
$ git checkout pull/102