8293492: ShenandoahControlThread missing from hs-err log and thread dump

[ashu-mehra]

Please review this patch to add ShenandoahControlThread to the thread list in hs_err log file and thread dump.

With this change, the hs_err log file contains the entry for ShenandoahControlThread in "Other Threads" section:

Other Threads:
=>0x00007f84d41c5d50 VMThread "VM Thread" [stack: 0x00007f84d8e8e000,0x00007f84d8f8e000] [id=278151]
  0x00007f84d42d5e00 WatcherThread "VM Periodic Task Thread" [stack: 0x00007f84d8280000,0x00007f84d8380000] [id=278163]
  0x00007f84d4107d80 ConcurrentGCThread "Shenandoah Control Thread" [stack: 0x00007f84d933a000,0x00007f84d943a000] [id=278150]
  0x00007f84d40b4dc0 WorkerThread "Shenandoah GC Threads#0" [stack: 0x00007f84d97bc000,0x00007f84d98bc000] [id=278145]
  ...

and Thread.print command (using jcmd) also has the entry for the thread:

"VM Thread" os_prio=0 cpu=0.46ms elapsed=6.85s tid=0x00007fe6dc1ca750 nid=265830 runnable  

"Shenandoah Control Thread" os_prio=0 cpu=13.34ms elapsed=6.87s tid=0x00007fe6dc10c780 nid=265829 runnable

"Shenandoah GC Threads#0" os_prio=0 cpu=0.12ms elapsed=6.91s tid=0x00007fe6dc0b3730 nid=265827 runnable  

I also cleaned up the code a bit to be consistent naming this thread.

Signed-off-by: Ashutosh Mehra asmehra@redhat.com

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293492: ShenandoahControlThread missing from hs-err log and thread dump

Reviewers

• Zhengyu Gu (@zhengyu123 - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10205/head:pull/10205
$ git checkout pull/10205

Update a local copy of the PR:
$ git checkout pull/10205
$ git pull https://git.openjdk.org/jdk pull/10205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10205

View PR using the GUI difftool:
$ git pr show -t 10205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10205.diff

[bridgekeeper]

👋 Welcome back ashu-mehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ashu-mehra The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (195e7877)

[zhengyu123]

LGTM

[openjdk]

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293492: ShenandoahControlThread missing from hs-err log and thread dump

Reviewed-by: zgu, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 195 new commits pushed to the master branch:

• 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
• 98da03a: 8293432: Use diamond operator in java.management
• ffc249a: 8289613: Drop use of Thread.stop in jshell
• 8d3399b: 8292758: put support for UNSIGNED5 format into its own header file
• 6677227: 8293497: Build failure due to MaxVectorSize was not declared when C2 is disabled after JDK-8293254
• 986b834: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
• fc5f97f: 8293474: RISC-V: Unify the way of moving function pointer
• 2d13f53: 8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode
• f84386c: 8293182: Improve testing of CDS archive heap
• 51de765: 8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "
• ... and 185 more: https://git.openjdk.org/jdk/compare/d24b7b7026cf85f1aecf44f60819762872cfd5c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@zhengyu123, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

Looks fine, thanks!

[ashu-mehra]

/integrate

[openjdk]

@ashu-mehra
Your change (at version 195e787) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 85ec1f8.
Since your change was applied there have been 195 commits pushed to the master branch:

• 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
• 98da03a: 8293432: Use diamond operator in java.management
• ffc249a: 8289613: Drop use of Thread.stop in jshell
• 8d3399b: 8292758: put support for UNSIGNED5 format into its own header file
• 6677227: 8293497: Build failure due to MaxVectorSize was not declared when C2 is disabled after JDK-8293254
• 986b834: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
• fc5f97f: 8293474: RISC-V: Unify the way of moving function pointer
• 2d13f53: 8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode
• f84386c: 8293182: Improve testing of CDS archive heap
• 51de765: 8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "
• ... and 185 more: https://git.openjdk.org/jdk/compare/d24b7b7026cf85f1aecf44f60819762872cfd5c1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @ashu-mehra Pushed as commit 85ec1f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[ashu-mehra]

@shipilev @zhengyu123 thanks for reviewing the changes and sponsoring it.