Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293524: RISC-V: Use macro-assembler functions as appropriate #10210

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Sep 8, 2022

Use of assember functions on riscv can be improved. For example, we use 'fence(0xf, 0xf)' in function TemplateInterpreterGenerator::generate_safept_entry_for to emit a full memory fence instruction. Here we should use 'membar(MacroAssembler::AnyAny)' instead, which would make the code more readable. This also replace some calls to 'li' with 'mv' so that it will be more consistent when moving integer constant.

Testing: Tier1 tested on Linux-riscv64 SiFive Unmatched board.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293524: RISC-V: Use macro-assembler functions as appropriate

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10210/head:pull/10210
$ git checkout pull/10210

Update a local copy of the PR:
$ git checkout pull/10210
$ git pull https://git.openjdk.org/jdk pull/10210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10210

View PR using the GUI difftool:
$ git pr show -t 10210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10210.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2022

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@RealFYang The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Sep 8, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293524: RISC-V: Use macro-assembler functions as appropriate

Reviewed-by: shade, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8d3399b: 8292758: put support for UNSIGNED5 format into its own header file
  • 6677227: 8293497: Build failure due to MaxVectorSize was not declared when C2 is disabled after JDK-8293254
  • 986b834: 8293489: Accept CAs with BasicConstraints without pathLenConstraint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2022
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up, thanks! (Not a JDK reviewer)

@RealFYang
Copy link
Member Author

@shipilev @feilongjiang : Thanks for reviewing this.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2022

Going to push as commit 43e191d.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 14eb5ad: 8291753: Add JFR event for GC CPU Time
  • 30d4145: 8293230: x86_64: Move AES and GHASH stub definitions into separate source files
  • 4c5501c: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
  • 46e6e41: 8293051: Further refactor javac after removal of -source/-target/--release 7
  • c0ee30a: 8293348: A false cyclic inheritance error reported
  • 85ec1f8: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
  • 98da03a: 8293432: Use diamond operator in java.management
  • ffc249a: 8289613: Drop use of Thread.stop in jshell
  • 8d3399b: 8292758: put support for UNSIGNED5 format into its own header file
  • ... and 2 more: https://git.openjdk.org/jdk/compare/fc5f97fe379825cb927666ae26aef00082cfae56...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 9, 2022
@openjdk openjdk bot closed this Sep 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 9, 2022
@openjdk
Copy link

openjdk bot commented Sep 9, 2022

@RealFYang Pushed as commit 43e191d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the JDK-8293524 branch September 9, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
3 participants