Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293544: G1: Add comment in G1BarrierSetC1::pre_barrier #10219

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Sep 8, 2022

A comment-only change in G1 pre-barrier to explain the redundant is-marking-active check.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293544: G1: Add comment in G1BarrierSetC1::pre_barrier

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10219/head:pull/10219
$ git checkout pull/10219

Update a local copy of the PR:
$ git checkout pull/10219
$ git pull https://git.openjdk.org/jdk pull/10219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10219

View PR using the GUI difftool:
$ git pr show -t 10219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10219.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8293544 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier Sep 8, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 8, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2022

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 9, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293544: G1: Add comment in G1BarrierSetC1::pre_barrier

Reviewed-by: kbarrett, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
  • 43e191d: 8293524: RISC-V: Use macro-assembler functions as appropriate
  • 14eb5ad: 8291753: Add JFR event for GC CPU Time
  • 30d4145: 8293230: x86_64: Move AES and GHASH stub definitions into separate source files
  • 4c5501c: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
  • 46e6e41: 8293051: Further refactor javac after removal of -source/-target/--release 7
  • c0ee30a: 8293348: A false cyclic inheritance error reported
  • 85ec1f8: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
  • 98da03a: 8293432: Use diamond operator in java.management
  • ... and 1 more: https://git.openjdk.org/jdk/compare/8d3399bf5f354931b0c62d2ed8095e554be71680...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2022
Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

Going to push as commit d5aae01.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 37df5f5: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 699c429: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
  • 005b49b: 8293044: C1: Missing access check on non-accessible class
  • 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
  • 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • dbec22b: 8293287: add ReplayReduce flag
  • b8598b0: 8291660: Grapheme support in BreakIterator
  • a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
  • 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
  • ... and 14 more: https://git.openjdk.org/jdk/compare/8d3399bf5f354931b0c62d2ed8095e554be71680...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2022
@openjdk openjdk bot closed this Sep 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@albertnetymk Pushed as commit d5aae01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-c1-comment branch September 12, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants