8293044: C1: Missing access check on non-accessible class

[iwanowww]

C1 erroneously omits some access checks on symbolically referenced classes.

Proposed fix relies on code patching to throw proper resolution error when required.

Also, to avoid repeated recompilations on platforms which don't support code
patching, the nmethod is not marked as non-entrant when corresponding constant
pool entry is in error state.

Testing: hs-tier1 - hs-tier4

/cc hotspot-compiler

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293044: C1: Missing access check on non-accessible class

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to cb9a7bb3
• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10222/head:pull/10222
$ git checkout pull/10222

Update a local copy of the PR:
$ git checkout pull/10222
$ git pull https://git.openjdk.org/jdk pull/10222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10222

View PR using the GUI difftool:
$ git pr show -t 10222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10222.diff

[bridgekeeper]

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iwanowww
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 02: Full - Incremental (ad69916a)
• 01: Full - Incremental (8a3286f7)
• 00: Full (cb9a7bb3)

[TobiHartmann]

Looks good to me otherwise.

[openjdk]

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293044: C1: Missing access check on non-accessible class

Reviewed-by: thartmann, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
• 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
• dbec22b: 8293287: add ReplayReduce flag
• b8598b0: 8291660: Grapheme support in BreakIterator
• a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
• 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
• 7169ee5: 8293477: IGV: Upgrade to Netbeans Platform 15
• 3dd94f3: 8292671: Hotspot Style Guide should allow covariant returns
• 9d6b028: 8234315: GTK LAF does not gray out disabled JMenu
• 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
• ... and 2 more: https://git.openjdk.org/jdk/compare/30d4145e2edd2d3e4cbaa8b01f7639ab53bc0991...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk-notifier]

@iwanowww Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[dean-long]

Looks good.

[iwanowww]

Thanks for the reviews, Tobias and Dean.

/integrate

[openjdk]

Going to push as commit 005b49b.
Since your change was applied there have been 12 commits pushed to the master branch:

• 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
• 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
• dbec22b: 8293287: add ReplayReduce flag
• b8598b0: 8291660: Grapheme support in BreakIterator
• a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
• 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
• 7169ee5: 8293477: IGV: Upgrade to Netbeans Platform 15
• 3dd94f3: 8292671: Hotspot Style Guide should allow covariant returns
• 9d6b028: 8234315: GTK LAF does not gray out disabled JMenu
• 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
• ... and 2 more: https://git.openjdk.org/jdk/compare/30d4145e2edd2d3e4cbaa8b01f7639ab53bc0991...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iwanowww Pushed as commit 005b49b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.