JDK-8293343 sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"

[bwhuang-us]

This task provides a fix for java.io.EOFException on RmiSslNoKeyStoreTest and RmiBootstrapTest.

The EOFException is only seen when tests are run in concurrent mode. It could be caused by a bug in prepareTestFiles() which creates a race condition that RmiBootstrapTest/RmiSslNoKeyStoreTest changes the file permissions while the other one reading the same files.

In addition, tests are failing intermittently for SocketException with agentvm mode.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
• JDK-8293335: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1failed with "Agent communication error: java.io.EOFException"

Reviewers

• Kevin Walls (@kevinjwalls - Committer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10224/head:pull/10224
$ git checkout pull/10224

Update a local copy of the PR:
$ git checkout pull/10224
$ git pull https://git.openjdk.org/jdk pull/10224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10224

View PR using the GUI difftool:
$ git pr show -t 10224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10224.diff

[bwhuang-us]

/issue JDK-8293335

[bridgekeeper]

👋 Welcome back bwhuang-us! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bwhuang-us
Adding additional issue to issue list: 8293335: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1failed with "Agent communication error: java.io.EOFException".

[openjdk]

@bwhuang-us The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[kevinjwalls]

Looks good, I've tested othervm and had success also.
One more thing - these tests are now in the problemlist, so we need to remove them from test/jdk/ProblemList.txt:

527 sun/management/jmxremote/bootstrap/RmiBootstrapTest.java 8293335 linux-x64
528 sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java 8293343 linux-aarch64,macosx-x64

[mlbridge]

Webrevs

• 00: Full (59481b46)

[kevinjwalls]

Looks good!

[openjdk]

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
8293335: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1failed with "Agent communication error: java.io.EOFException"

Reviewed-by: kevinw, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• b8598b0: 8291660: Grapheme support in BreakIterator
• a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
• 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
• 7169ee5: 8293477: IGV: Upgrade to Netbeans Platform 15
• 3dd94f3: 8292671: Hotspot Style Guide should allow covariant returns
• 9d6b028: 8234315: GTK LAF does not gray out disabled JMenu
• 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
• 43e191d: 8293524: RISC-V: Use macro-assembler functions as appropriate

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinjwalls, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bwhuang-us]

/integrate

[openjdk]

@bwhuang-us
Your change (at version 59481b4) is now ready to be sponsored by a Committer.

[kevinjwalls]

/sponsor

[openjdk]

Going to push as commit 91c9091.
Since your change was applied there have been 17 commits pushed to the master branch:

• 4c77bd3: 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler
• d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
• 37df5f5: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
• 699c429: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
• 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
• 005b49b: 8293044: C1: Missing access check on non-accessible class
• 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
• 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
• dbec22b: 8293287: add ReplayReduce flag
• b8598b0: 8291660: Grapheme support in BreakIterator
• ... and 7 more: https://git.openjdk.org/jdk/compare/14eb5ad0dc987ffe3621f4eeeebeb6b5a2cd691b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls @bwhuang-us Pushed as commit 91c9091.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.