-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288473: Remove unused frame::set_pc_preserve_deopt methods #10233
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up! I agree this is a trivial fix so you don't have to wait 24 hours.
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks Ron and Dan. I'm waiting for GHA to finish then I'll push. |
All GHA platforms built. Thanks for the reviews. |
Going to push as commit 91d00b3.
Your commit was automatically rebased without conflicts. |
Please review this trivial change to remove unused functions.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10233/head:pull/10233
$ git checkout pull/10233
Update a local copy of the PR:
$ git checkout pull/10233
$ git pull https://git.openjdk.org/jdk pull/10233/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10233
View PR using the GUI difftool:
$ git pr show -t 10233
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10233.diff