Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288473: Remove unused frame::set_pc_preserve_deopt methods #10233

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Sep 9, 2022

Please review this trivial change to remove unused functions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288473: Remove unused frame::set_pc_preserve_deopt methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10233/head:pull/10233
$ git checkout pull/10233

Update a local copy of the PR:
$ git checkout pull/10233
$ git pull https://git.openjdk.org/jdk pull/10233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10233

View PR using the GUI difftool:
$ git pr show -t 10233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10233.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2022
@openjdk
Copy link

openjdk bot commented Sep 9, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 9, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up! I agree this is a trivial fix so you don't have to wait 24 hours.

@openjdk
Copy link

openjdk bot commented Sep 9, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288473: Remove unused frame::set_pc_preserve_deopt methods

Reviewed-by: rpressler, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • dbec22b: 8293287: add ReplayReduce flag
  • b8598b0: 8291660: Grapheme support in BreakIterator
  • a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2022
@coleenp
Copy link
Contributor Author

coleenp commented Sep 9, 2022

Thanks Ron and Dan. I'm waiting for GHA to finish then I'll push.

@coleenp
Copy link
Contributor Author

coleenp commented Sep 9, 2022

All GHA platforms built. Thanks for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2022

Going to push as commit 91d00b3.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • dbec22b: 8293287: add ReplayReduce flag
  • b8598b0: 8291660: Grapheme support in BreakIterator
  • a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 9, 2022
@openjdk openjdk bot closed this Sep 9, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 9, 2022
@coleenp coleenp deleted the loom-functions branch September 9, 2022 20:20
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 9, 2022
@openjdk
Copy link

openjdk bot commented Sep 9, 2022

@coleenp Pushed as commit 91d00b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants