Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293647: Avoid unnecessary boxing in jdk.hotspot.agent #10237

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 12, 2022

Usages of methods Integer.valueOf, Boolean.valueOf, Long.valueOf often can be simplified by using their pair methods parseInt/parseBoolean/parseLong.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293647: Avoid unnecessary boxing in jdk.hotspot.agent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10237/head:pull/10237
$ git checkout pull/10237

Update a local copy of the PR:
$ git checkout pull/10237
$ git pull https://git.openjdk.org/jdk pull/10237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10237

View PR using the GUI difftool:
$ git pr show -t 10237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10237.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 12, 2022
@turbanoff turbanoff changed the title [PATCH] Avoid unnecessary boxing in jdk.hotspot.agent 8293647: Avoid unnecessary boxing in jdk.hotspot.agent Sep 12, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293647: Avoid unnecessary boxing in jdk.hotspot.agent

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 8bd79d3: 8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages
  • 9cd3e35: 4834298: JFileChooser.getSelectedFiles() failed with multi-selection and double-click
  • ec2629c: 8275275: AArch64: Fix performance regression after auto-vectorization on NEON
  • cbee0bc: 8292587: AArch64: Support SVE fabd instruction
  • 68645eb: 8293566: RISC-V: Clean up push and pop registers
  • 526eb54: 8293669: SA: Remove unnecssary "InstanceStackChunkKlass: InstanceStackChunkKlass" output when scanning heap
  • 41ce658: 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses
  • 155b10a: 8293329: x86: Improve handling of constants in AES/GHASH stubs
  • d3f7e3b: 8293339: vm/jvmti/StopThread/stop001/stop00103 crashes with SIGSEGV in Continuation::is_continuation_mounted
  • 524af94: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64
  • ... and 4 more: https://git.openjdk.org/jdk/compare/4c77bd32a0d2cfbdd15e58a9b48f6952d52e7156...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2022
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2022

Going to push as commit 7e02039.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 9039022: 8287394: AArch64: Remove cbuf parameter from far_call/far_jump/trampoline_call
  • 1dc5039: 8293626: AccessFlag::locations(ClassFileFormatVersion cffv) does not throw NPEx when parameter is null
  • 6f2223f: 8288180: C2: VectorPhase must ensure that SafePointNode memory input is a MergeMemNode
  • 725f41f: 8293351: Add second tmp register to aarch64 BarrierSetAssembler::load_at
  • 37234c8: 8291912: Introduce per-allocation target struct for members in G1PLABAllocator
  • 1e1db5d: 8292591: Experimentally add back barrier-less Java thread transitions
  • dfc16e0: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread
  • 8bd79d3: 8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages
  • 9cd3e35: 4834298: JFileChooser.getSelectedFiles() failed with multi-selection and double-click
  • ec2629c: 8275275: AArch64: Fix performance regression after auto-vectorization on NEON
  • ... and 11 more: https://git.openjdk.org/jdk/compare/4c77bd32a0d2cfbdd15e58a9b48f6952d52e7156...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2022
@openjdk openjdk bot closed this Sep 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@turbanoff Pushed as commit 7e02039.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the unnecessary_boxing_in_jdk.hotspot.agent branch October 27, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants