Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293669: SA: Remove unnecssary "InstanceStackChunkKlass: InstanceStackChunkKlass" output when scanning heap #10245

Closed

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Sep 12, 2022

Get rid of the following "debugging" output that was introduced in the loom repo:

InstanceStackChunkKlass: InstanceStackChunkKlass

I'd like to push this as a trivial change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293669: SA: Remove unnecssary "InstanceStackChunkKlass: InstanceStackChunkKlass" output when scanning heap

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10245/head:pull/10245
$ git checkout pull/10245

Update a local copy of the PR:
$ git checkout pull/10245
$ git pull https://git.openjdk.org/jdk pull/10245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10245

View PR using the GUI difftool:
$ git pr show -t 10245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10245.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8293669 8293669: SA: Remove unnecssary "InstanceStackChunkKlass: InstanceStackChunkKlass" output when scanning heap Sep 12, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@plummercj The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org labels Sep 12, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2022

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this fix is trivial.
Looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293669: SA: Remove unnecssary "InstanceStackChunkKlass: InstanceStackChunkKlass" output when scanning heap

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • 41ce658: 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses
  • 155b10a: 8293329: x86: Improve handling of constants in AES/GHASH stubs
  • d3f7e3b: 8293339: vm/jvmti/StopThread/stop001/stop00103 crashes with SIGSEGV in Continuation::is_continuation_mounted
  • 524af94: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64
  • cea409c: 8292738: JInternalFrame backgroundShadowBorder & foregroundShadowBorder line is longer in Mac Look and Feel
  • 9ef6c09: 8287908: Use non-cloning reflection methods where acceptable
  • 0c61bf1: 8293282: LoadLibraryUnloadTest.java fails with "Too few cleared WeakReferences"
  • 91c9091: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 4c77bd3: 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler
  • d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
  • ... and 52 more: https://git.openjdk.org/jdk/compare/85d4b49151e9529051f1ed344749a487d3e92165...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2022
@plummercj
Copy link
Contributor Author

/label remove hotspot-gc

@openjdk openjdk bot removed the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@plummercj
The hotspot-gc label was successfully removed.

@plummercj
Copy link
Contributor Author

Thanks, Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

Going to push as commit 526eb54.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 41ce658: 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses
  • 155b10a: 8293329: x86: Improve handling of constants in AES/GHASH stubs
  • d3f7e3b: 8293339: vm/jvmti/StopThread/stop001/stop00103 crashes with SIGSEGV in Continuation::is_continuation_mounted
  • 524af94: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64
  • cea409c: 8292738: JInternalFrame backgroundShadowBorder & foregroundShadowBorder line is longer in Mac Look and Feel
  • 9ef6c09: 8287908: Use non-cloning reflection methods where acceptable
  • 0c61bf1: 8293282: LoadLibraryUnloadTest.java fails with "Too few cleared WeakReferences"
  • 91c9091: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 4c77bd3: 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler
  • d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
  • ... and 52 more: https://git.openjdk.org/jdk/compare/85d4b49151e9529051f1ed344749a487d3e92165...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2022
@openjdk openjdk bot closed this Sep 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@plummercj Pushed as commit 526eb54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8293669_InstanceStackChunkKlass branch October 11, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants