-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8293768: Add links to JLS 19 and 20 from SourceVersion enum constants #10257
Conversation
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links look good assuming current pattern of link names. Specification landing page rather than 404 verified.
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d191e47.
Your commit was automatically rebased without conflicts. |
Originally, I was only going to add a link to JLS 19 for when the docs for Java SE 19 went live, but at time of writing the JLS 19 link goes to the specifications landing page rather than giving a 404. Therefore, adding links to both JLS 19 and 20 know aren't dead links per se and will become better links as the JLS 19 and 20 pages are published in the future.
When the resolved JLS-version-specific links resolving the specification home page, the future I'll add the link to the specific JLS version when I add a new SourceVersion constant.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10257/head:pull/10257
$ git checkout pull/10257
Update a local copy of the PR:
$ git checkout pull/10257
$ git pull https://git.openjdk.org/jdk pull/10257/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10257
View PR using the GUI difftool:
$ git pr show -t 10257
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10257.diff