8293782: Shenandoah: some tests failed on lock rank check

[tbzhang]

After JDK-8290025, some tests using ShenandoahGC failed on the lock rank check between AdapterHandlerLibrary_lock and ShenandoahRequestedGC_lock

Symptom

#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/data1/ws/jdk/src/hotspot/share/runtime/mutex.cpp:454), pid=2018566, tid=2022220
# assert(false) failed: Attempting to acquire lock ShenandoahRequestedGC_lock/safepoint-1 out of order with lock AdapterHandlerLibrary_lock/safepoint-1 -- possible deadlock
#
# JRE version: OpenJDK Runtime Environment (20.0) (slowdebug build 20-internal-adhoc.root.jdk)
# Java VM: OpenJDK 64-Bit Server VM (slowdebug 20-internal-adhoc.root.jdk, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, shenandoah gc, linux-amd64)
# Problematic frame:
# V [libjvm.so+0x106fd6a] Mutex::check_rank(Thread*)+0x426

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293782: Shenandoah: some tests failed on lock rank check

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 23f44fbd
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10264/head:pull/10264
$ git checkout pull/10264

Update a local copy of the PR:
$ git checkout pull/10264
$ git pull https://git.openjdk.org/jdk pull/10264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10264

View PR using the GUI difftool:
$ git pr show -t 10264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10264.diff

[bridgekeeper]

👋 Welcome back tbzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tbzhang The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (87675608)
• 00: Full (23f44fbd)

[TheRealMDoerr]

We have tested it for a couple of days and there were no new failures. LGTM.

[openjdk]

@tbzhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293782: Shenandoah: some tests failed on lock rank check

Reviewed-by: mdoerr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 327 new commits pushed to the master branch:

• 4435d56: 8282395: URL.openConnection can throw IOOBE
• fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
• 97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
• 5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
• e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
• 9d116ec: 8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine
• 4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
• 891156a: 8295003: Do not mention applets in the "java.awt.color" package
• e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
• 1bfcc27: 8294931: JFR: Simplify SettingInfo
• ... and 317 more: https://git.openjdk.org/jdk/compare/1169a1593660242375400e9d6b9ca11a872cdf02...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

So we can now enter this code when holding AdapterHandlerLibrary_lock, which has a rank of safepoint-1. These locks should probably match the rank of Heap_lock, which is safepoint-2 now. Please update _alloc_failure_waiters_lock rank as well.

[tbzhang]

Thanks for reminding! updated the rank of _alloc_failure_waiters_lock

[shipilev]

This looks good, thank you! (I tested hotspot:tier1 with Shenandoah, and it now passes cleanly)

[tbzhang]

Thanks for reviews! @shipilev @TheRealMDoerr

[tbzhang]

/integrate

[openjdk]

@tbzhang
Your change (at version 8767560) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 6053bf0.
Since your change was applied there have been 327 commits pushed to the master branch:

• 4435d56: 8282395: URL.openConnection can throw IOOBE
• fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
• 97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
• 5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
• e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
• 9d116ec: 8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine
• 4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
• 891156a: 8295003: Do not mention applets in the "java.awt.color" package
• e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
• 1bfcc27: 8294931: JFR: Simplify SettingInfo
• ... and 317 more: https://git.openjdk.org/jdk/compare/1169a1593660242375400e9d6b9ca11a872cdf02...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @tbzhang Pushed as commit 6053bf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.