8293591: Remove use of Thread.stop from jshell tests

[lahodaj]

Two changes here:

• confirming the '/exit` command, so that the JShell instance is actually stopped
• removing the call to Thread.stop, which is intended to stop the test if something goes wrong unexpectedly. As we cannot use Thread.stop anymore, we'll rely on jtreg to stop the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293591: Remove use of Thread.stop from jshell tests

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10271/head:pull/10271
$ git checkout pull/10271

Update a local copy of the PR:
$ git checkout pull/10271
$ git pull https://git.openjdk.org/jdk pull/10271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10271

View PR using the GUI difftool:
$ git pr show -t 10271

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10271.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (35fc6d54)

[AlanBateman]

Leaving it to jtreg when something goes wrong and the test times out seems right. Thanks for doing this.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293591: Remove use of Thread.stop from jshell tests

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• aff5ff1: 8244681: Add a warning for possibly lossy conversion in compound assignments
• 15cb1fb: 8256265: G1: Improve parallelism in regions that failed evacuation
• b31a03c: 8293695: Implement isInfinite intrinsic for RISC-V
• 8f3bbe9: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
• 1caba0f: 8292948: JEditorPane ignores font-size styles in external linked css-file
• eeb625e: 8290169: adlc: Improve child constraints for vector unary operations
• 2057070: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
• 7376c55: 8293769: RISC-V: Add a second temporary register for BarrierSetAssembler::load_at
• d191e47: 8293768: Add links to JLS 19 and 20 from SourceVersion enum constants
• a75ddb8: 8293122: (fs) Use file cloning in macOS version of Files::copy method
• ... and 2 more: https://git.openjdk.org/jdk/compare/7f3250d71c4866a64eb73f52140c669fe90f122f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[lahodaj]

Leaving it to jtreg when something goes wrong and the test times out seems right. Thanks for doing this.

Thanks!

[openjdk]

Going to push as commit fbd8b42.
Since your change was applied there have been 12 commits pushed to the master branch:

• aff5ff1: 8244681: Add a warning for possibly lossy conversion in compound assignments
• 15cb1fb: 8256265: G1: Improve parallelism in regions that failed evacuation
• b31a03c: 8293695: Implement isInfinite intrinsic for RISC-V
• 8f3bbe9: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
• 1caba0f: 8292948: JEditorPane ignores font-size styles in external linked css-file
• eeb625e: 8290169: adlc: Improve child constraints for vector unary operations
• 2057070: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
• 7376c55: 8293769: RISC-V: Add a second temporary register for BarrierSetAssembler::load_at
• d191e47: 8293768: Add links to JLS 19 and 20 from SourceVersion enum constants
• a75ddb8: 8293122: (fs) Use file cloning in macOS version of Files::copy method
• ... and 2 more: https://git.openjdk.org/jdk/compare/7f3250d71c4866a64eb73f52140c669fe90f122f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit fbd8b42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.