-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8271328: User is able to choose the color after disabling the color chooser. #10276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kumarabhi006! A progress list of the required criteria for merging this PR into |
|
@kumarabhi006 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| import java.awt.event.ItemListener; | ||
| import java.awt.Point; | ||
| import java.awt.Robot; | ||
| import javax.swing.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please import only used swing components/functionalities. Can remove the generic swing.* import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the import statements.
|
@kumarabhi006 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 865 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@kumarabhi006 |
|
/sponsor |
|
Going to push as commit b920d29.
Your commit was automatically rebased without conflicts. |
|
@prsadhuk @kumarabhi006 Pushed as commit b920d29. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The proposed solution for this defect is to check the color chooser enabled state. If it is disabled then disable all the components (spinner, textfield etc.) in panel and don't process the mouse event when user click on a color triangle or color wheel.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10276/head:pull/10276$ git checkout pull/10276Update a local copy of the PR:
$ git checkout pull/10276$ git pull https://git.openjdk.org/jdk pull/10276/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10276View PR using the GUI difftool:
$ git pr show -t 10276Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10276.diff