-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293844: C2: Verify Location::{oop,normal} types in PhaseOutput::FillLocArray #10281
8293844: C2: Verify Location::{oop,normal} types in PhaseOutput::FillLocArray #10281
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. I will test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My tier1-4 and xcomp testing passed too.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I did not check that the types checked by the new asserts are exhaustive.
Thanks! /integrate |
Going to push as commit 26e08cf.
Your commit was automatically rebased without conflicts. |
I have been debugging a weird issue in C2/deopt, and wanted to have stronger asserts in critical paths. One such place is
PhaseOutput::FillLocArray
, which emitsLocation::normal
on unconditionalelse
branch.Location::normal
is described as "Ints, floats, double halves". I think we would be better off verifying the types explicitly. Same goes forLocation::oop
, which we can also verify.Aside: In fact, I suspect the whole
Regalloc::is_oop
business can go away, and we can rely on reg types to sense if we are dealing with oops here, but that looks like a change with some unexpected effects, so I would like to do that separately, see JDK-8293845.Additional testing:
tier1
tier2
tier1
tier2
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10281/head:pull/10281
$ git checkout pull/10281
Update a local copy of the PR:
$ git checkout pull/10281
$ git pull https://git.openjdk.org/jdk pull/10281/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10281
View PR using the GUI difftool:
$ git pr show -t 10281
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10281.diff