8293813: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64 in Xcomp mode

[kevinjwalls]

Add com/sun/jdi/JdbLastErrorTest.java to test/jdk/ProblemList-Xcomp.txt

The test fails immediately with -Xcomp, logged JDK-8293829 to look at that further.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293813: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64 in Xcomp mode

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10288/head:pull/10288
$ git checkout pull/10288

Update a local copy of the PR:
$ git checkout pull/10288
$ git pull https://git.openjdk.org/jdk pull/10288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10288

View PR using the GUI difftool:
$ git pr show -t 10288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10288.diff

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[plummercj]

Usually we file a new issue for problem listing (as a subtask of the main issue). Also, it's not clear to me that JDK-8293813 is now simply a dup of your newly filed JDK-8293829.

[dcubed-ojdk]

Should this be windows-x64 instead of generic-all?

[kevinjwalls]

Yes, updating that. I was thinking it might save some time somewhere to make it generic, but that's probably overthinking.

[dcubed-ojdk]

I've updated the synopsis for this bug. Please use "/issue JDK-8293813"
to reset the PR's title.

[dcubed-ojdk]

In the analysis of:
JDK-8293829 Windows native last error value cleared with -Xcomp or -Xint (but not neither)

it mentions that this test can also fail with -Xint. As far as I know, we don't
do any runs with '-Xint' so the ProblemListing for just -Xcomp should be okay.

[kevinjwalls]

/issue JDK-8293813

[kevinjwalls]

Thanks Dan for tidying up!

[openjdk]

@kevinjwalls This issue is referenced in the PR title - it will now be updated.

[kevinjwalls]

Usually we file a new issue for problem listing (as a subtask of the main issue). Also, it's not clear to me that JDK-8293813 is now simply a dup of your newly filed JDK-8293829.

Thanks Chris - yes after Dan tidying up it might look more as you expect. They are for sure the same issue.

[dcubed-ojdk]

Thumbs up. This is a trivial fix and does not need to wait 24 hours.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293813: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64 in Xcomp mode

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 4cec141: 8291509: Minor cleanup could be done in sun.security
• 6beeb84: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
• bf79f99: 8292989: Avoid dynamic memory in AsyncLogWriter
• 2028ec7: 8289608: Change com/sun/jdi tests to not use Thread.suspend/resume
• ecb456a: 8293779: redundant checking in AESCrypt.makeSessionKey() method
• 6fca9ae: 8288474: Move EventContinuationFreezeOld from try_freeze_fast to freeze_slow
• fbd8b42: 8293591: Remove use of Thread.stop from jshell tests
• aff5ff1: 8244681: Add a warning for possibly lossy conversion in compound assignments
• 15cb1fb: 8256265: G1: Improve parallelism in regions that failed evacuation
• b31a03c: 8293695: Implement isInfinite intrinsic for RISC-V
• ... and 8 more: https://git.openjdk.org/jdk/compare/211fab8d361822bbd1a34a88626853bf4a029af5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit bb9aa4e.
Since your change was applied there have been 18 commits pushed to the master branch:

• 4cec141: 8291509: Minor cleanup could be done in sun.security
• 6beeb84: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
• bf79f99: 8292989: Avoid dynamic memory in AsyncLogWriter
• 2028ec7: 8289608: Change com/sun/jdi tests to not use Thread.suspend/resume
• ecb456a: 8293779: redundant checking in AESCrypt.makeSessionKey() method
• 6fca9ae: 8288474: Move EventContinuationFreezeOld from try_freeze_fast to freeze_slow
• fbd8b42: 8293591: Remove use of Thread.stop from jshell tests
• aff5ff1: 8244681: Add a warning for possibly lossy conversion in compound assignments
• 15cb1fb: 8256265: G1: Improve parallelism in regions that failed evacuation
• b31a03c: 8293695: Implement isInfinite intrinsic for RISC-V
• ... and 8 more: https://git.openjdk.org/jdk/compare/211fab8d361822bbd1a34a88626853bf4a029af5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit bb9aa4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kevinjwalls]

it mentions that this test can also fail with -Xint. As far as I know, we don't do any runs with '-Xint' so the ProblemListing for just -Xcomp should be okay.

OK great. Regarding -Xint, that seems reliable but can fail after quite a while, like 25mins of continual testing. Even if we did test with -Xint this test is not likely to fail (which I write, of course, to try and provoke a failure).