8293816: CI: ciBytecodeStream::get_klass() is not consistent

[iwanowww]

CI responses should be consistent during a single compilation.

JDK-8293044 was fixed by turning inaccessible classes into unloaded ones when resolving them through CI.

But there's another case when ciEnv::get_klass_by_index() returns a loaded ciKlass while setting will_link to false: a not-yet-resolved klass revealed through a class loader constraint.

In such case, after a concurrent class loading CI will start reporting a loaded ciKlass instance. Such inconsistency may trigger some paradoxical situations during compilation.

The fix is to instantiate a proper instance of an unloaded ciKlass, so further requests will return the unloaded instances as well.

Testing: hs-tier1 - hs-tier4

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293816: CI: ciBytecodeStream::get_klass() is not consistent

Reviewers

• Dean Long (@dean-long - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10294/head:pull/10294
$ git checkout pull/10294

Update a local copy of the PR:
$ git checkout pull/10294
$ git pull https://git.openjdk.org/jdk pull/10294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10294

View PR using the GUI difftool:
$ git pr show -t 10294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10294.diff

[bridgekeeper]

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iwanowww The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (64d8e150)

[dean-long]

Makes sense.

[openjdk]

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293816: CI: ciBytecodeStream::get_klass() is not consistent

Reviewed-by: dlong, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 9a40b76: 8293842: IPv6-only systems throws UnsupportedOperationException for several socket/TCP options
• bb9aa4e: 8293813: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64 in Xcomp mode
• 4cec141: 8291509: Minor cleanup could be done in sun.security

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Good.

[iwanowww]

Thanks for the reviews, Dean and Vladimir.

/integrate

[openjdk]

Going to push as commit 746f5f5.
Since your change was applied there have been 12 commits pushed to the master branch:

• 4b297c1: 8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants
• dfb9c06: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx
• f42caef: 8293550: Optionally add get-task-allow entitlement to macos binaries
• 5feca68: 8293840: RISC-V: Remove cbuf parameter from far_call/far_jump/trampoline_call
• 39cd163: 8293578: Duplicate ldc generated by javac
• 7765942: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
• 11e7d53: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"
• 141d5f5: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
• 3beca2d: 8291600: [vectorapi] vector cast op check is not always needed for vector mask cast
• 9a40b76: 8293842: IPv6-only systems throws UnsupportedOperationException for several socket/TCP options
• ... and 2 more: https://git.openjdk.org/jdk/compare/6beeb8471ccf140e59864d7f983e1d9ad741309c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iwanowww Pushed as commit 746f5f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.