8293886: The abstract keyword can be removed in AESCipher

[XueleiFan]

Hi,

Please review this simple fix for readability.

In the AES cipher implementation, the AESCipher class is defined as abstract. As is not necessary as there is no abstract method in this class. Code reader may try to search for abstract methods if the abstract keyword is present.

BTW, I also added Override tags and make a few other cleanup, for example adding the 'final' keywords.

Thanks,
Xuelei

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293886: The abstract keyword can be removed in AESCipher

Reviewers

• Anthony Scarpino (@ascarpino - Reviewer) ⚠️ Review applies to defa6e5d
• Bradford Wetmore (@bradfordwetmore - Reviewer) ⚠️ Review applies to defa6e5d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10297/head:pull/10297
$ git checkout pull/10297

Update a local copy of the PR:
$ git checkout pull/10297
$ git pull https://git.openjdk.org/jdk pull/10297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10297

View PR using the GUI difftool:
$ git pr show -t 10297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10297.diff

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (350bbe1b)
• 00: Full (defa6e5d)

[bridgekeeper]

@XueleiFan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[XueleiFan]

ping ...

[ascarpino]

The change looks fine

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293886: The abstract keyword can be removed in AESCipher

Reviewed-by: ascarpino, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 93fed9b: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bradfordwetmore]

Two minor nits, but otherwise looks good.

[bradfordwetmore]

If you're doing general cleaning, line 33 import ByteBuffer can go, and there's an extra line in the javadoc at line 53 that could also go.

[XueleiFan]

Yes. I will make the cleanup as well.

[XueleiFan]

/integrate

[openjdk]

Going to push as commit d6468be.
Since your change was applied there have been 11 commits pushed to the master branch:

• 54c986e: 8296715: CLDR v42 update for tzdata 2022f
• 4a68210: 6972078: Can not select single directory with GTKLookAndFeel
• 4465361: 8295948: Support for Zicbop/prefetch instructions on RISC-V
• f2acdfd: 8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT
• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• 78a08a0: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop
• f0a6e71: 8295812: Skip the "half float" support in LittleCMS during the build
• 79c0092: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents
• ... and 1 more: https://git.openjdk.org/jdk/compare/d6e2d0d03d2161f934474fa1d4299513d14cb9c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@XueleiFan Pushed as commit d6468be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.