8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum

[tschatzl]

Hi all,

please review this fix to a test that performs the faulty assumptions that collections take more than one ms.

Testing: local testing, passes even with changes to the test configuration that reproduce the issue 100%

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10303/head:pull/10303
$ git checkout pull/10303

Update a local copy of the PR:
$ git checkout pull/10303
$ git pull https://git.openjdk.org/jdk pull/10303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10303

View PR using the GUI difftool:
$ git pr show -t 10303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10303.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (290a349a)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 5feca68: 8293840: RISC-V: Remove cbuf parameter from far_call/far_jump/trampoline_call
• 39cd163: 8293578: Duplicate ldc generated by javac
• 7765942: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
• 11e7d53: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"
• 141d5f5: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
• 3beca2d: 8291600: [vectorapi] vector cast op check is not always needed for vector mask cast
• 9a40b76: 8293842: IPv6-only systems throws UnsupportedOperationException for several socket/TCP options
• bb9aa4e: 8293813: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64 in Xcomp mode
• 4cec141: 8291509: Minor cleanup could be done in sun.security
• 6beeb84: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
• ... and 49 more: https://git.openjdk.org/jdk/compare/37df5f56259429482cfdbe38e8b6256f1efaf9e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[tschatzl]

Thanks @kimbarrett @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit d77c464.
Since your change was applied there have been 73 commits pushed to the master branch:

• d7c1a76: 8293861: G1: Disable preventive GCs by default
• 43f7f47: 8293499: Provide jmod --compress option
• 26e08cf: 8293844: C2: Verify Location::{oop,normal} types in PhaseOutput::FillLocArray
• 357a2cc: 8293937: x86: Drop LP64 conditions from clearly x86_32 code
• b1ed40a: 8293466: libjsig should ignore non-modifying sigaction calls
• b6ff8fa: 8292073: NMT: remove unused constructor parameter from MallocHeader
• cfd44bb: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"
• 01e7b88: 8290917: x86: Memory-operand arithmetic instructions have too low costs
• 4b8399b: 8293251: Use stringStream::base() instead of as_string() when applicable
• a8f0f57: 8278165: Clarify that ZipInputStream does not access the CEN fields for a ZipEntry
• ... and 63 more: https://git.openjdk.org/jdk/compare/37df5f56259429482cfdbe38e8b6256f1efaf9e8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit d77c464.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.