Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255798: Remove dead headless code in CompileJavaModules.gmk #1031

Closed
wants to merge 1 commit into from

Conversation

@magicus
Copy link
Member

@magicus magicus commented Nov 3, 2020

The variable BUILD_HEADLESS_ONLY is no longer set. And sun/applet does not exist anymore.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255798: Remove dead headless code in CompileJavaModules.gmk

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1031/head:pull/1031
$ git checkout pull/1031

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2020

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@magicus The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2020

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 3, 2020

/label add awt
/label remove core-libs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@AlanBateman Unknown command labels - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@AlanBateman Unknown command labels - for a list of valid commands use /help.

@magicus
Copy link
Member Author

@magicus magicus commented Nov 3, 2020

/label add awt
/label remove core-libs

@openjdk openjdk bot added the awt label Nov 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@magicus
The awt label was successfully added.

@openjdk openjdk bot removed the core-libs label Nov 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@magicus
The core-libs label was successfully removed.

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255798: Remove dead headless code in CompileJavaModules.gmk

Reviewed-by: shade, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 93ef009: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs
  • 63461d5: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown
  • b8d4e02: 8255374: Add a dropReturn MethodHandle combinator
  • 1d0bd50: 8254758: Change G1ServiceThread to be task based
  • 9a0cf58: 8255615: Zero: demote ZeroStack::abi_stack_available guarantee to assert
  • 904561e: 8255719: Zero: on return path, check for pending exception before attempting to clear it
  • 9bd836e: 8255744: Zero: handle JVM_CONSTANT_DynamicInError
  • 36998b0: 8255716: AArch64: Regression: JVM crashes if manually offline a core
  • 4107670: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 3, 2020
erikj79
erikj79 approved these changes Nov 3, 2020
@magicus
Copy link
Member Author

@magicus magicus commented Nov 3, 2020

/integrate

@openjdk openjdk bot closed this Nov 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@magicus Since your change was applied there have been 11 commits pushed to the master branch:

  • 364b0fe: 8255801: Race when building ct.sym build tools
  • f389a71: 8255737: Zero: DO_UPDATE_INSTRUCTION_COUNT should only update when relevant VM flags are set
  • 93ef009: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs
  • 63461d5: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown
  • b8d4e02: 8255374: Add a dropReturn MethodHandle combinator
  • 1d0bd50: 8254758: Change G1ServiceThread to be task based
  • 9a0cf58: 8255615: Zero: demote ZeroStack::abi_stack_available guarantee to assert
  • 904561e: 8255719: Zero: on return path, check for pending exception before attempting to clear it
  • 9bd836e: 8255744: Zero: handle JVM_CONSTANT_DynamicInError
  • 36998b0: 8255716: AArch64: Regression: JVM crashes if manually offline a core
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/9a367479279f46494d83356f34eddd29ab0045b1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 64a9811.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the remove-dead-headless-code branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants