8293781: RISC-V: Clarify types of calls

[yhzhu20]

RISCV64 OpenJDK uses different types of calls in generated calls. It should be clarified what they are. And the PR also cleans up some out-of-date comments.

HotSpot tier1 tests passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293781: RISC-V: clarify types of calls

Reviewers

• Feilong Jiang (@feilongjiang - Author)
• Fei Yang (@RealFYang - Reviewer)
• Yadong Wang (@yadongw - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10311/head:pull/10311
$ git checkout pull/10311

Update a local copy of the PR:
$ git checkout pull/10311
$ git pull https://git.openjdk.org/jdk pull/10311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10311

View PR using the GUI difftool:
$ git pr show -t 10311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10311.diff

[bridgekeeper]

👋 Welcome back yzhu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yhzhu20 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8293781
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@yhzhu20 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (ee810dbd)
• 03: Full - Incremental (49355876)
• 02: Full - Incremental (9e77d750)
• 01: Full (5e99b407)
• 00: Full (20adc315)

[openjdk-notifier]

@yhzhu20 Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[feilongjiang]

Looks good, with one comment:

[feilongjiang]

s/AArch64/RISC-V

[yhzhu20]

Done.

[RealFYang]

Looks good. Thanks.

[openjdk]

@yhzhu20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293781: RISC-V: Clarify types of calls

Reviewed-by: fjiang, fyang, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 1b49606: 8293922: Extend barrier-less Java thread transitions to native transitions
• a07902b: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*
• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[feilongjiang]

New change looks good.

[yhzhu20]

/integrate

[openjdk]

@yhzhu20
Your change (at version ee810db) is now ready to be sponsored by a Committer.

[yadongw]

lgtm(not a reviewer)

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 84ee1a2.
Since your change was applied there have been 4 commits pushed to the master branch:

• 1b49606: 8293922: Extend barrier-less Java thread transitions to native transitions
• a07902b: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*
• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @yhzhu20 Pushed as commit 84ee1a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.