8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

[phohensee]

Trivial change to get a test to run reliably on Shenandoah and ZGC.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10319/head:pull/10319
$ git checkout pull/10319

Update a local copy of the PR:
$ git checkout pull/10319
$ git pull https://git.openjdk.org/jdk pull/10319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10319

View PR using the GUI difftool:
$ git pr show -t 10319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10319.diff

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@phohensee The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d203b357)

[tschatzl]

I would have kind of preferred a solution that made sure that would have waited for completion of a gc using mxbeans or so, but this seems good enough for a test.

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName
• 4020ed5: 8293210: G1: Remove redundant check in G1FreeHumongousRegionClosure
• 8ff2c26: 8293942: [JVMCI] data section entries must be 4-byte aligned on AArch64
• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• 1f9ff41: 8292297: Fix up loading of override java.security properties file
• 64b96e5: 8293811: Provide a reason for PassFailJFrame.forceFail
• f91762f: 8293965: Code signing warnings after JDK-8293550
• 8082c24: 8054572: [macosx] JComboBox paints the border incorrectly
• b920d29: 8271328: User is able to choose the color after disabling the color chooser.
• ... and 21 more: https://git.openjdk.org/jdk/compare/dfb9c0663370fc8335caf06ca6f0cb4dac95ce2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

This change also looks trivial to me.

[phohensee]

Pre-submit test failures appear to be infrastructure issues.

[phohensee]

/integrate

Thanks for the prompt review, Thomas.

[openjdk]

Going to push as commit 5002eaa.
Since your change was applied there have been 40 commits pushed to the master branch:

• e3358e7: 8294008: Grapheme implementation of setText() throws IndexOutOfBoundsException
• df8ec09: 8294046: Newly added test test/jdk/javax/swing/JTabbedPane/TestNPEStateChgListener.java fails in macos
• 09af637: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6
• 584de68: 8294058: Early use of lambda introduced in JDK-8285263 cause startup regressions in 20-b02
• bb422f5: 8293595: tstrings::any() is missing an overload
• 0f28cb0: 8294014: Remove redundant UseCompiler conditions
• 84ee1a2: 8293781: RISC-V: Clarify types of calls
• 1b49606: 8293922: Extend barrier-less Java thread transitions to native transitions
• a07902b: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*
• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• ... and 30 more: https://git.openjdk.org/jdk/compare/dfb9c0663370fc8335caf06ca6f0cb4dac95ce2d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit 5002eaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.