Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8255681: print callstack in error case in runAWTLoopWithApp #1032

Closed
wants to merge 1 commit into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 3, 2020

Currently in case of occurences of an NSException in runAWTLoopWithApp we catch the exception just print a simple error message like this :

2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot lock focus on image <NSImage 0x7fd350d7f9f0 Size={0, 0} RepProvider=(null)>, because it is size zero.
2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event Thread

But we omit the callstack and loose valuable information. This change adds the callstack to the output.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255681: print callstack in error case in runAWTLoopWithApp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1032/head:pull/1032
$ git checkout pull/1032

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2020

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@MBaesken The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2020

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

To me this looks like a good idea. In our current customer case this information would have greatly helped analysis. However, I'd like to see an opinion from one of the experts in that area on whether that's appropriate here.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2020

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255681: print callstack in error case in runAWTLoopWithApp

Reviewed-by: clanger, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 83f3cf4: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
  • 134e22a: 8255606: Enable concurrent stack processing on x86_32 platforms
  • ca216ba: 8255810: Zero: build fails without JVMTI
  • d47336b: 8248320: Provide a unique accessible name for
  • 64a9811: 8255798: Remove dead headless code in CompileJavaModules.gmk
  • 364b0fe: 8255801: Race when building ct.sym build tools
  • f389a71: 8255737: Zero: DO_UPDATE_INSTRUCTION_COUNT should only update when relevant VM flags are set
  • 93ef009: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs
  • 63461d5: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown
  • b8d4e02: 8255374: Add a dropReturn MethodHandle combinator
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/4107670d6210df16d5afd0ac7b8a7bab04a29c3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 3, 2020
mrserb
mrserb approved these changes Nov 3, 2020
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Nov 4, 2020

/integrate

@openjdk openjdk bot closed this Nov 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 4, 2020
@MBaesken MBaesken deleted the JDK-8255681 branch Nov 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2020

@MBaesken Since your change was applied there have been 28 commits pushed to the master branch:

  • c7a2c24: 8255797: ciReplay: improve documentation of replay file syntax in parser
  • a5d8a9c: 8255617: Zero: purge the remaining bytecode interpreter profiling support
  • 4b88119: 8253037: G1: Improve check for string dedup
  • 2668d23: 8255861: Also update jaotc.1 for JDK 16
  • 76fa974: 8255850: Hotspot recompiled on first incremental build
  • 622f72b: 8255853: Update all nroff manpages for JDK 16 release
  • cdf9cd8: 8255784: appcds/javaldr/ExceptionDuringDumpAtObjectsInitPhase.java test failed resulting in VM crash
  • eab99f3: 8255852: Shenandoah: Fix incorrect copyright header in new files added by 8254315
  • 450452b: 8254876: (fs) NullPointerException not thrown when first argument to Path.of or Paths.get is null
  • b46d73b: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/4107670d6210df16d5afd0ac7b8a7bab04a29c3b...master

Your commit was automatically rebased without conflicts.

Pushed as commit ab9192e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants