-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294067: [macOS] javax/swing/JComboBox/6559152/bug6559152.java Cannot select an item from popup with the ENTER key. #10359
8294067: [macOS] javax/swing/JComboBox/6559152/bug6559152.java Cannot select an item from popup with the ENTER key. #10359
Conversation
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
Webrevs
|
I note that the mouse click was added to stabilise this test in this PR @prsadhuk was it really needed ? The comment back then was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would prefer to keep the click for better test stability.
Let's hear some thoughts from other reviewers.
EDIT: looks like I am not the only one concerning about this.
@@ -99,9 +99,6 @@ private static void setupUI() { | |||
private static void test() throws Exception { | |||
robot.mouseMove(p.x, p.y); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still need this? There is no more mouse click.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-added the mouse click and took Prasanta's advice to just center the mouse on the combobox, instead of adding to the y position by 1.
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 801 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint, @prsadhuk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I think the click is needed to gain focus in some CI systems.. I guess probably the right fix will be to do Also, better to run in all platforms after the test fix and put in JBS. |
@@ -97,7 +98,7 @@ private static void setupUI() { | |||
} | |||
|
|||
private static void test() throws Exception { | |||
robot.mouseMove(p.x, p.y); | |||
robot.mouseMove(p.x + cb.getWidth() / 2, p.y + cb.getHeight() / 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since cb
is swing component, appropriate will be to do
(Dimension) d = comp.getSize(); inside blockTillDisplayed() which is called in EDT
and use mouseMove(p.x + d.width/2, p.y + d.height/2)
/integrate |
/sponsor |
Going to push as commit 3b438a6.
Your commit was automatically rebased without conflicts. |
The newly fix-sized JComboBox has its dropdown menu opened with this test's mouse click. The goal of the test is to focus the JComboBox, open the dropdown menu, and select the 2nd option of the menu using arrow keys and ENTER key. Since the JComboBox is focused without the click already, the click can be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10359/head:pull/10359
$ git checkout pull/10359
Update a local copy of the PR:
$ git checkout pull/10359
$ git pull https://git.openjdk.org/jdk pull/10359/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10359
View PR using the GUI difftool:
$ git pr show -t 10359
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10359.diff