8294110: compiler/uncommontrap/Decompile.java fails after JDK-8293798

[DamonFool]

It fails with release VMs.

STDERR:
Error: VM option 'AlwaysIncrementalInline' is develop and is available only in debug version of VM.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

-XX:+IgnoreUnrecognizedVMOptions is added to fix it.

Thanks.
Best regards,
Jie

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294110: compiler/uncommontrap/Decompile.java fails after JDK-8293798

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10374/head:pull/10374
$ git checkout pull/10374

Update a local copy of the PR:
$ git checkout pull/10374
$ git pull https://git.openjdk.org/jdk pull/10374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10374

View PR using the GUI difftool:
$ git pr show -t 10374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10374.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4b585ba5)

[shipilev]

Another test from original change, compiler/intrinsics/klass/CastNullCheckDroppingsTest.java, seems to already do the same.

So, looks fine.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294110: compiler/uncommontrap/Decompile.java fails after JDK-8293798

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d14e96d: 8293493: Signal Handlers printout should show signal block state
• da4fdfb: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Good and trivial.

[DamonFool]

Thanks @shipilev and @TobiHartmann .
/integrate

[openjdk]

Going to push as commit 07afa3f.
Since your change was applied there have been 4 commits pushed to the master branch:

• 0746bcb: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers
• 95ec2ea: 8293897: Synthetic final modifier is part of the AST for a try-with-resource resource
• d14e96d: 8293493: Signal Handlers printout should show signal block state
• da4fdfb: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 07afa3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.