Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll #10377

Closed
wants to merge 2 commits into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Sep 21, 2022

Please review this patch that fixes the warning JNI local refs ... exceeds capacity on Windows machines running with IPv6 stack enabled.

This case was missed in JDK-8187450 / #2963.

I verified that with this patch applied, the warning does not appear on a machine with 60+ interfaces. Tier2 also passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10377/head:pull/10377
$ git checkout pull/10377

Update a local copy of the PR:
$ git checkout pull/10377
$ git pull https://git.openjdk.org/jdk pull/10377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10377

View PR using the GUI difftool:
$ git pr show -t 10377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8294115 8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@djelinski The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Sep 21, 2022
@djelinski djelinski marked this pull request as ready for review September 21, 2022 16:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

  • 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
  • 8491fd5: 8294551: Put java/io/BufferedInputStream/TransferTo.java on problem list
  • 6f8f28e: 8294160: misc crash dump improvements
  • 8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
  • 76f1865: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
  • 9db95ed: 8215788: Clarify JarInputStream Manifest access
  • 9309786: 8294472: Remove redundant rawtypes suppression in AbstractChronology
  • 3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
  • 4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
  • 7515b30: 8279283: BufferedInputStream should override transferTo
  • ... and 111 more: https://git.openjdk.org/jdk/compare/bb422f5c14745bf29bc2cb741f819a17c8400543...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2022
@djelinski
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2022

Going to push as commit 9dce865.
Since your change was applied there have been 130 commits pushed to the master branch:

  • b030c7d: 8225235: Unused field defaultIndex in NetworkInterface
  • a07975b: 8294519: (fs) java/nio/file/Files/CopyProcFile.java fails intermittenly due to unstable /proc/cpuinfo output
  • 88062ee: 8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic
  • aeef3ec: 8294198: Implement isFinite intrinsic for RISC-V
  • 5f6ad92: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException
  • 545ded1: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
  • 29c70f1: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list
  • 5d48da4: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()
  • ce85cac: 8065554: MatchResult should provide values of named-capturing groups
  • 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
  • ... and 120 more: https://git.openjdk.org/jdk/compare/bb422f5c14745bf29bc2cb741f819a17c8400543...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2022
@openjdk openjdk bot closed this Sep 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2022
@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@djelinski Pushed as commit 9dce865.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the jni-warning branch October 20, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants