8294160: misc crash dump improvements #10387

dean-long · 2022-09-22T07:53:42Z

Try to recover and output meaningful information in more situations, such as:

when a pointer is in Method metadata memory range, but the memory is not committed
when we call a bad address

When calling a bad address, we usually don't get a meaningful stack backtrace, but in many situations we can if we know where to find the caller information.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294160: misc crash dump improvements

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Vladimir Ivanov (@iwanowww - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10387/head:pull/10387
$ git checkout pull/10387

Update a local copy of the PR:
$ git checkout pull/10387
$ git pull https://git.openjdk.org/jdk pull/10387/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10387

View PR using the GUI difftool:
$ git pr show -t 10387

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10387.diff

bridgekeeper · 2022-09-22T07:54:08Z

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-22T07:57:03Z

@dean-long The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-22T10:13:00Z

Webrevs

01: Full - Incremental (ec02ee5f)
00: Full (a06a47a2)

dean-long · 2022-09-23T23:18:57Z

/cc hotspot-runtime
/cc hotspot-compiler

openjdk · 2022-09-23T23:20:48Z

@dean-long
The hotspot-runtime label was successfully added.

openjdk · 2022-09-23T23:22:40Z

@dean-long
The hotspot-compiler label was successfully added.

dholmes-ora

I'm not familiar with all the aspects of this in enough detail so just a couple of observational comments.

src/hotspot/os/posix/signals_posix.cpp

src/hotspot/share/utilities/vmError.cpp

dholmes-ora · 2022-09-28T01:24:34Z

src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp

@@ -348,7 +354,7 @@ void os::print_tos_pc(outputStream *st, const void *context) {
  // Note: it may be unsafe to inspect memory near pc. For example, pc may
  // point to garbage if entry point in an nmethod is corrupted. Leave
  // this at the end, and hope for the best.
-  address pc = os::Posix::ucontext_get_pc(uc);
+  address pc = os::fetch_frame_from_context(uc).pc();


What is the difference between ucontext_get_pc(uc) and getting the pc from the frame from the uc? How many pc's can a ucontext have?

The former returns the PC where the crash happened, which could be in unreadable memory. Blindly inspecting that memory will cause error reporting to crash. The latter returns the PC of a frame constructed from the context, and possibly adjusted to reflect where the caller was when it made the bad call, which is more useful for getting stack backtraces and less likely to crash error reporting. When error reporting crashes we recover, but we don't get the information it was dumping when it crashed.

dholmes-ora

Okay seems quite reasonable. Thanks.

openjdk · 2022-09-28T04:27:36Z

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294160: misc crash dump improvements

Reviewed-by: dholmes, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
76f1865: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
9db95ed: 8215788: Clarify JarInputStream Manifest access
9309786: 8294472: Remove redundant rawtypes suppression in AbstractChronology
3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
7515b30: 8279283: BufferedInputStream should override transferTo
7401fe0: 8292912: Make guard card in CardTable inaccessible
70d8428: 8294520: Problemlist java/nio/file/Files/CopyProcFile.java
30e3bf9: 8291805: IGV: Improve Zooming
... and 77 more: https://git.openjdk.org/jdk/compare/2283c3244f4fe475593d8a53613b5a3228bec356...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dean-long · 2022-09-28T06:39:14Z

Thanks David.

iwanowww

Looks good.

dean-long · 2022-09-28T23:12:51Z

Thanks Vladimir.

dean-long · 2022-09-28T23:13:04Z

/integrate

openjdk · 2022-09-28T23:15:13Z

Going to push as commit 6f8f28e.
Since your change was applied there have been 87 commits pushed to the master branch:

8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
76f1865: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
9db95ed: 8215788: Clarify JarInputStream Manifest access
9309786: 8294472: Remove redundant rawtypes suppression in AbstractChronology
3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
7515b30: 8279283: BufferedInputStream should override transferTo
7401fe0: 8292912: Make guard card in CardTable inaccessible
70d8428: 8294520: Problemlist java/nio/file/Files/CopyProcFile.java
30e3bf9: 8291805: IGV: Improve Zooming
... and 77 more: https://git.openjdk.org/jdk/compare/2283c3244f4fe475593d8a53613b5a3228bec356...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-28T23:15:32Z

@dean-long Pushed as commit 6f8f28e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dean-long added 4 commits September 22, 2022 04:11

better crash dumps, linux x86

f5e86b9

linux aarch64 support, simplify x86

5295360

revert

f1074e9

linux x86 print_instructions

95c8a51

openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 22, 2022

windows x86

a06a47a

dean-long marked this pull request as ready for review September 22, 2022 10:05

openjdk bot added the rfr Pull request is ready for review label Sep 22, 2022

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 23, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 23, 2022

dholmes-ora reviewed Sep 27, 2022

View reviewed changes

src/hotspot/os/posix/signals_posix.cpp Show resolved Hide resolved

src/hotspot/share/utilities/vmError.cpp Outdated Show resolved Hide resolved

revert unneeded changes

ec02ee5

dholmes-ora reviewed Sep 28, 2022

View reviewed changes

dholmes-ora approved these changes Sep 28, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2022

iwanowww approved these changes Sep 28, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 28, 2022

openjdk bot closed this Sep 28, 2022

openjdk bot removed the ready Pull request is ready to be integrated label Sep 28, 2022

openjdk bot removed the rfr Pull request is ready for review label Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8294160: misc crash dump improvements #10387

8294160: misc crash dump improvements #10387

dean-long commented Sep 22, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 22, 2022

openjdk bot commented Sep 22, 2022

mlbridge bot commented Sep 22, 2022 •

edited

Loading

dean-long commented Sep 23, 2022

openjdk bot commented Sep 23, 2022

openjdk bot commented Sep 23, 2022

dholmes-ora left a comment

dholmes-ora Sep 28, 2022

dean-long Sep 28, 2022

dholmes-ora left a comment

openjdk bot commented Sep 28, 2022 •

edited

Loading

dean-long commented Sep 28, 2022

iwanowww left a comment

dean-long commented Sep 28, 2022

dean-long commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

8294160: misc crash dump improvements #10387

8294160: misc crash dump improvements #10387

Conversation

dean-long commented Sep 22, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 22, 2022

openjdk bot commented Sep 22, 2022

mlbridge bot commented Sep 22, 2022 • edited Loading

Webrevs

dean-long commented Sep 23, 2022

openjdk bot commented Sep 23, 2022

openjdk bot commented Sep 23, 2022

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Sep 28, 2022

Choose a reason for hiding this comment

dean-long Sep 28, 2022

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 28, 2022 • edited Loading

dean-long commented Sep 28, 2022

iwanowww left a comment

Choose a reason for hiding this comment

dean-long commented Sep 28, 2022

dean-long commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

dean-long commented Sep 22, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 22, 2022 •

edited

Loading

openjdk bot commented Sep 28, 2022 •

edited

Loading