-
Notifications
You must be signed in to change notification settings - Fork 6.2k
6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. #10390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. #10390
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f8aed0
JFileChooser combobox and selection textarea displayed directory list…
kumarabhi006 ff3bce2
Comment added and test case condotion update
kumarabhi006 698a120
Review comment fix and test case changed to manual
kumarabhi006 c7493bf
Review comment fix
kumarabhi006 7b9b74f
Test moved to plaf/gtk folder
kumarabhi006 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserDirectorySelection.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 6777156 | ||
| * @library /java/awt/regtesthelpers | ||
| * @build PassFailJFrame | ||
| * @requires (os.family == "linux") | ||
| * @summary Verifies if user is not able to select "../" beyond | ||
| * root file system. | ||
| * @run main/manual TestFileChooserDirectorySelection | ||
| */ | ||
|
|
||
| import javax.swing.JFileChooser; | ||
| import javax.swing.JFrame; | ||
| import javax.swing.SwingUtilities; | ||
| import javax.swing.UIManager; | ||
|
|
||
| public class TestFileChooserDirectorySelection { | ||
| private static JFrame frame; | ||
| private static final String INSTRUCTIONS = | ||
| "Double click on the \"../\" entry from directory list.\n\n" + | ||
| "Repeat the same process till the current directory is root " + | ||
| "i.e \" / \" .\n\n" + | ||
| "If \" ../ \" option is not available at root directory" + | ||
| ", press Pass else Fail."; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel"); | ||
| PassFailJFrame passFailJFrame = new PassFailJFrame( | ||
| "JFileChooser Test Instructions", INSTRUCTIONS, 5, 8, 35); | ||
| try { | ||
| SwingUtilities.invokeAndWait( | ||
| TestFileChooserDirectorySelection::createAndShowUI); | ||
| passFailJFrame.awaitAndCheck(); | ||
| } finally { | ||
| SwingUtilities.invokeAndWait(() -> { | ||
| if (frame != null) { | ||
| frame.dispose(); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| private static void createAndShowUI() { | ||
| frame = new JFrame("Test File Chooser Directory Selection"); | ||
| JFileChooser fileChooser = new JFileChooser(); | ||
| fileChooser.setControlButtonsAreShown(false); | ||
| PassFailJFrame.addTestWindow(frame); | ||
| PassFailJFrame.positionTestWindow( | ||
| frame, PassFailJFrame.Position.HORIZONTAL); | ||
| frame.add(fileChooser); | ||
| frame.setSize(500, 500); | ||
| frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); | ||
| frame.setVisible(true); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to use "FileSystemView.isFileSystemRoot(File)" for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked this.
Do you mean to check
FileSystemView.isFileSystemRoot(crntDir )?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's what you commented "if current directory is root"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... I will check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.