8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes #10392

bulasevich · 2022-09-22T14:30:10Z

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes

Reviewers

Dean Long (@dean-long - Reviewer) ⚠️ Review applies to 59ff8c44
Doug Simon (@dougxc - Committer) ⚠️ Review applies to 102e33c7

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10392/head:pull/10392
$ git checkout pull/10392

Update a local copy of the PR:
$ git checkout pull/10392
$ git pull https://git.openjdk.org/jdk pull/10392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10392

View PR using the GUI difftool:
$ git pr show -t 10392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10392.diff

bridgekeeper · 2022-09-22T14:41:40Z

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-22T14:44:27Z

@bulasevich The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-10-23T09:11:45Z

Webrevs

dougxc · 2022-10-24T08:36:45Z

src/hotspot/share/asm/codeBuffer.hpp

+#if INCLUDE_JVMCI
+    if (EnableJVMCI) {
+      // Graal vectorization requires larger aligned constants
+      return 64;


This means all Graal installed code will pay a penalty even though most installed code does not include constants that need such large alignment. It would be preferable to allow a compiler to specify the alignment requirement per nmethod.

I agree. The alignment should probably be a field in CodeBuffer with a default value of 8.

openjdk-notifier · 2022-10-28T06:29:59Z

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

… larger than 8 bytes

… alignment for all JVMCI nmethods

openjdk-notifier · 2022-10-28T06:46:54Z

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

dean-long

Looks good.

openjdk · 2022-10-28T07:16:36Z

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes

Reviewed-by: dlong, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

823fd4a: 8293785: Add a jtreg test for TraceOptoParse
754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dougxc · 2022-10-28T10:10:03Z

src/hotspot/share/asm/codeBuffer.hpp

@@ -456,6 +454,9 @@ class CodeBuffer: public StackObj DEBUG_ONLY(COMMA private Scrubber) {
    _insts.initialize_outer(this,  SECT_INSTS);
    _stubs.initialize_outer(this,  SECT_STUBS);

+    // default value. should be changed if vectorization requires large aligned constants


I would not make this comment so vectorization specific. Just say something like:

// Default is to align on 8 bytes. A compiler can change this // if larger alignment (e.g., 32-byte vector masks) is required.

bulasevich · 2022-10-29T14:06:28Z

thanks!

bulasevich · 2022-10-29T14:06:40Z

/integrate

openjdk · 2022-10-29T14:08:44Z

Going to push as commit f3ca0ca.
Since your change was applied there have been 9 commits pushed to the master branch:

8aa1526: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
a44ebd5: 8295849: Consolidate Threads::owning_thread*
1c86cf5: 8294672: Typo in description of JDWP VirtualMachine/AllThreads command
823fd4a: 8293785: Add a jtreg test for TraceOptoParse
754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Your commit was automatically rebased without conflicts.

openjdk · 2022-10-29T14:09:06Z

@bulasevich Pushed as commit f3ca0ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 22, 2022

bulasevich force-pushed the 8293999_graal_constSectionAlignment branch 2 times, most recently from 9823817 to 86a1e9a Compare October 5, 2022 13:07

bulasevich force-pushed the 8293999_graal_constSectionAlignment branch from 86a1e9a to 851d58b Compare October 13, 2022 15:15

bulasevich force-pushed the 8293999_graal_constSectionAlignment branch 2 times, most recently from 7a08f87 to 80693ef Compare October 21, 2022 09:17

bulasevich marked this pull request as ready for review October 23, 2022 09:06

openjdk bot added the rfr Pull request is ready for review label Oct 23, 2022

dougxc reviewed Oct 24, 2022

View reviewed changes

bulasevich added 2 commits October 28, 2022 06:44

8293999: [JVMCI] need support for aligned constants in generated code…

c19e065

… larger than 8 bytes

adding CodeSection._const_section_alignment field instead of 64 bytes…

59ff8c4

… alignment for all JVMCI nmethods

bulasevich force-pushed the 8293999_graal_constSectionAlignment branch from f743a42 to 59ff8c4 Compare October 28, 2022 06:44

dean-long approved these changes Oct 28, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2022

arm32 fix

102e33c

dougxc reviewed Oct 28, 2022

View reviewed changes

dougxc approved these changes Oct 28, 2022

View reviewed changes

comment update

19be053

openjdk bot added the integrated Pull request has been integrated label Oct 29, 2022

openjdk bot closed this Oct 29, 2022

openjdk bot removed the ready Pull request is ready to be integrated label Oct 29, 2022

openjdk bot removed the rfr Pull request is ready for review label Oct 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes #10392

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes #10392

bulasevich commented Sep 22, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 22, 2022

openjdk bot commented Sep 22, 2022

mlbridge bot commented Oct 23, 2022 •

edited

Loading

dougxc Oct 24, 2022

dean-long Oct 25, 2022

openjdk-notifier bot commented Oct 28, 2022

openjdk-notifier bot commented Oct 28, 2022

dean-long left a comment

openjdk bot commented Oct 28, 2022 •

edited

Loading

dougxc Oct 28, 2022 •

edited

Loading

bulasevich commented Oct 29, 2022

bulasevich commented Oct 29, 2022

openjdk bot commented Oct 29, 2022

openjdk bot commented Oct 29, 2022

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes #10392

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes #10392

Conversation

bulasevich commented Sep 22, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 22, 2022

openjdk bot commented Sep 22, 2022

mlbridge bot commented Oct 23, 2022 • edited Loading

Webrevs

dougxc Oct 24, 2022

Choose a reason for hiding this comment

dean-long Oct 25, 2022

Choose a reason for hiding this comment

openjdk-notifier bot commented Oct 28, 2022

openjdk-notifier bot commented Oct 28, 2022

dean-long left a comment

Choose a reason for hiding this comment

openjdk bot commented Oct 28, 2022 • edited Loading

dougxc Oct 28, 2022 • edited Loading

Choose a reason for hiding this comment

bulasevich commented Oct 29, 2022

bulasevich commented Oct 29, 2022

openjdk bot commented Oct 29, 2022

openjdk bot commented Oct 29, 2022

bulasevich commented Sep 22, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 23, 2022 •

edited

Loading

openjdk bot commented Oct 28, 2022 •

edited

Loading

dougxc Oct 28, 2022 •

edited

Loading