Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync #10399

Closed
wants to merge 1 commit into from

Conversation

SWinxy
Copy link
Contributor

@SWinxy SWinxy commented Sep 23, 2022

I also took the opportunity to link to realSync(long).

/**
  * Parameterless version of realsync which uses default timout (see DEFAUL_WAIT_TIME).
  */
/**
  * Parameterless version of {@link #realSync(long)} which uses
  * the default timeout of {@link #DEFAULT_WAIT_TIME}.
  */

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10399/head:pull/10399
$ git checkout pull/10399

Update a local copy of the PR:
$ git checkout pull/10399
$ git pull https://git.openjdk.org/jdk pull/10399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10399

View PR using the GUI difftool:
$ git pr show -t 10399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10399.diff

@SWinxy
Copy link
Contributor Author

SWinxy commented Sep 23, 2022

/label client

bot? ya good?

@SWinxy
Copy link
Contributor Author

SWinxy commented Sep 23, 2022

/label client

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2022

👋 Welcome back SWinxy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Sep 23, 2022
@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@SWinxy
The client label was successfully added.

@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@SWinxy The client label was already applied.

@mlbridge
Copy link

mlbridge bot commented Sep 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@SWinxy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 136 new commits pushed to the master branch:

  • b22a38d: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
  • 121d4a5: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform
  • 1166a8a: 8292214: Memory leak in getAllConfigs of awt_GraphicsEnv.c:386
  • 3644e26: 8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java
  • 085949a: 8294712: G1: Use index-base iteration for G1FlushHumongousCandidateRemSets
  • b850f05: 8294758: JFR: Docs build fails after changes to RecordedObject and Timespan
  • 2dbedf0: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE
  • 4d6668e: 8294242: JFR: jfr print doesn't handle infinite duration well
  • 5a9cd33: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
  • f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • ... and 126 more: https://git.openjdk.org/jdk/compare/df53fa752a81a88b9495978cccb3d7b9f5ed553c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2022
@SWinxy
Copy link
Contributor Author

SWinxy commented Oct 4, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@SWinxy
Your change (at version 083f0fa) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Oct 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit b2e86a6.
Since your change was applied there have been 136 commits pushed to the master branch:

  • b22a38d: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
  • 121d4a5: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform
  • 1166a8a: 8292214: Memory leak in getAllConfigs of awt_GraphicsEnv.c:386
  • 3644e26: 8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java
  • 085949a: 8294712: G1: Use index-base iteration for G1FlushHumongousCandidateRemSets
  • b850f05: 8294758: JFR: Docs build fails after changes to RecordedObject and Timespan
  • 2dbedf0: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE
  • 4d6668e: 8294242: JFR: jfr print doesn't handle infinite duration well
  • 5a9cd33: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
  • f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • ... and 126 more: https://git.openjdk.org/jdk/compare/df53fa752a81a88b9495978cccb3d7b9f5ed553c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@prrace @SWinxy Pushed as commit b2e86a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@SWinxy SWinxy deleted the 8294255 branch January 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants