8294270: make test passes awkward -status:-status:error,fail to jtreg

[shipilev]

JDK-8230067 added jtreg retries, but it does so awkwardly: it sets export JTREG_STATUS="-status:error,fail"; on retry, and then uses it as -status:$$$${JTREG_STATUS}.

Which means we end up passing either: -status: or -status:-status:error,fail to jtreg. I confirmed this by also instrumenting the local jtreg build.

Now, it is not a problem for current jtreg, because it checks the status codes awkwardly with String.contains:
https://github.com/openjdk/jtreg/blob/aeb552e6df73e039e20de59b3ec847f36ab6e202/src/share/classes/com/sun/javatest/regtest/tool/Tool.java#L1635-L1640

But it will be a problem if jtreg ever starts to validate the arguments properly. I propose we fix this in current build system.

Additional testing:

• Eyeballing test reports from artificially intermittently failing tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294270: make test passes awkward -status:-status:error,fail to jtreg

Reviewers

• Daniel Jeliński (@djelinski - Committer)
• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10404/head:pull/10404
$ git checkout pull/10404

Update a local copy of the PR:
$ git checkout pull/10404
$ git pull https://git.openjdk.org/jdk pull/10404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10404

View PR using the GUI difftool:
$ git pr show -t 10404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10404.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b5455d57)

[djelinski]

LGTM

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294270: make test passes awkward -status:-status:error,fail to jtreg

Reviewed-by: djelinski, erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• e45f3d5: 8294281: Allow warnings to be disabled on a per-file basis
• 664e5b1: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
• acd75e0: 8294053: Unneeded local variable in handle_safefetch()
• 0b56b82: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions
• acd5bcf: 8289610: Degrade Thread.stop
• 05c8cab: 8293532: Use lighter jmod compression levels in build config
• eec992c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
• f6d78cd: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• a4dc035: 8290910: Wrong memory state is picked in SuperWord::co_locate_pack()
• f3ba332: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
• ... and 4 more: https://git.openjdk.org/jdk/compare/f751e6087d24012ecc0e6bc74d5572794a7c85d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

Thanks!

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit 6ecd081.
Since your change was applied there have been 16 commits pushed to the master branch:

• eca9749: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
• 2e20e7e: 8294271: Remove use of ThreadDeath from make utilities
• e45f3d5: 8294281: Allow warnings to be disabled on a per-file basis
• 664e5b1: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
• acd75e0: 8294053: Unneeded local variable in handle_safefetch()
• 0b56b82: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions
• acd5bcf: 8289610: Degrade Thread.stop
• 05c8cab: 8293532: Use lighter jmod compression levels in build config
• eec992c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
• f6d78cd: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• ... and 6 more: https://git.openjdk.org/jdk/compare/f751e6087d24012ecc0e6bc74d5572794a7c85d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 6ecd081.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.