8294281: Allow warnings to be disabled on a per-file basis

[magicus]

There have been a long-standing need to be able to disable individual warnings, not only per library, but also per C/C++ file in a library.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294281: Allow warnings to be disabled on a per-file basis

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10408/head:pull/10408
$ git checkout pull/10408

Update a local copy of the PR:
$ git checkout pull/10408
$ git pull https://git.openjdk.org/jdk pull/10408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10408

View PR using the GUI difftool:
$ git pr show -t 10408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10408.diff

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (163985cf)

[erikj79]

I think this looks good, but could you provide an example of how this would be used in the bug?

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294281: Allow warnings to be disabled on a per-file basis

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• 664e5b1: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
• acd75e0: 8294053: Unneeded local variable in handle_safefetch()
• 0b56b82: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions
• acd5bcf: 8289610: Degrade Thread.stop
• 05c8cab: 8293532: Use lighter jmod compression levels in build config
• eec992c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
• f6d78cd: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• a4dc035: 8290910: Wrong memory state is picked in SuperWord::co_locate_pack()
• f3ba332: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
• df53fa7: 8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key
• ... and 68 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit e45f3d5.
Since your change was applied there have been 78 commits pushed to the master branch:

• 664e5b1: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
• acd75e0: 8294053: Unneeded local variable in handle_safefetch()
• 0b56b82: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions
• acd5bcf: 8289610: Degrade Thread.stop
• 05c8cab: 8293532: Use lighter jmod compression levels in build config
• eec992c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
• f6d78cd: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• a4dc035: 8290910: Wrong memory state is picked in SuperWord::co_locate_pack()
• f3ba332: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
• df53fa7: 8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key
• ... and 68 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit e45f3d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[shqking]

I think this looks good, but could you provide an example of how this would be used in the bug?

Hi, #10414 shows an example.