Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292780: misc tests failed "assert(false) failed: graph should be schedulable" #10410

Closed
wants to merge 2 commits into from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Sep 23, 2022

PhaseMacroExpand::generate_partial_inlining_block() adds
LoadVectorMasked nodes to the IR graph and then
LoadNode::split_through_phi() tries to split one of them through phi
but because that method ignores the mask input to that LoadNode (it
only knows about control, memory and address inputs) the resulting
graph is broken. Fix I propose is to skip
LoadNode::split_through_phi() for those LoadVector nodes that have
extra inputs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8292780: misc tests failed "assert(false) failed: graph should be schedulable"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10410/head:pull/10410
$ git checkout pull/10410

Update a local copy of the PR:
$ git checkout pull/10410
$ git pull https://git.openjdk.org/jdk pull/10410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10410

View PR using the GUI difftool:
$ git pr show -t 10410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10410.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2022

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2022
@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 23, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2022

Webrevs

Copy link
Member

@dean-long dean-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a reasonable bailout.

@dean-long
Copy link
Member

/reviewers 2

@dean-long
Copy link
Member

@jatin-bhateja, please review this.

@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292780: misc tests failed "assert(false) failed: graph should be schedulable"

Reviewed-by: dlong, chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 2be3158: 4797982: Setting negative size of JSplitPane divider leads to unexpected results.
  • 050eebf: 8294245: Make Compile::print_inlining_stream stack allocated
  • 91a23d7: 8294142: make test should report only on executed tests
  • 169a5d4: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory
  • 3675f4c: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics
  • 543851d: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume
  • e2f8251: 8293618: x86: Wrong code generation in class Assembler
  • 6ecd081: 8294270: make test passes awkward -status:-status:error,fail to jtreg
  • eca9749: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • 2e20e7e: 8294271: Remove use of ThreadDeath from make utilities
  • ... and 5 more: https://git.openjdk.org/jdk/compare/05c8cabdad7b5c573046b1c5d235c33ac5cb266c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2022
@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@dean-long
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 23, 2022
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable!

src/hotspot/share/opto/memnode.cpp Outdated Show resolved Hide resolved
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2022
@TobiHartmann
Copy link
Member

So this is a regression from JDK-8252848, correct?

@rwestrel
Copy link
Contributor Author

So this is a regression from JDK-8252848, correct?

Yes.

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the affected versions. The fix looks good to me.

@rwestrel
Copy link
Contributor Author

@jatin-bhateja, please review this.

Hi @dean-long I have 3 reviews and the fix is fairly straightforward. Can I integrate or should I wait for @jatin-bhateja ?

@dean-long
Copy link
Member

@jatin-bhateja, please review this.

Hi @dean-long I have 3 reviews and the fix is fairly straightforward. Can I integrate or should I wait for @jatin-bhateja ?

I think it's fine to integrate this now because it fixes the problem, but I thought @jatin-bhateja might have an improvement to the fix that doesn't involve bailing out of the optimization. Maybe file a follow-up RFE for that?

@rwestrel
Copy link
Contributor Author

rwestrel commented Oct 4, 2022

I think it's fine to integrate this now because it fixes the problem, but I thought @jatin-bhateja might have an improvement to the fix that doesn't involve bailing out of the optimization. Maybe file a follow-up RFE for that?

I filed: https://bugs.openjdk.org/browse/JDK-8294750

@rwestrel
Copy link
Contributor Author

rwestrel commented Oct 4, 2022

Thanks @dean-long @TobiHartmann @chhagedorn for the reviews.

@rwestrel
Copy link
Contributor Author

rwestrel commented Oct 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit 16047e8.
Since your change was applied there have been 119 commits pushed to the master branch:

  • bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
  • ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
  • 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
  • 090cdfc: 8294726: Update URLs in minefield tests
  • ed40d88: 8276849: Refresh the window icon on graphics configuration changes
  • 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
  • a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
  • c6e3daa: 8242115: C2 SATB barriers are not safepoint-safe
  • e137f9f: 8293877: Rewrite MineField test
  • ... and 109 more: https://git.openjdk.org/jdk/compare/05c8cabdad7b5c573046b1c5d235c33ac5cb266c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@rwestrel Pushed as commit 16047e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants