8294317: Insufficient build rules for tzdb.dat

[naotoj]

The current makefile for tzdb.dat won't recompile if some dependent files (e.g. VERSION) are updated. Adding all files under the tzdb directory to the dependency will fix this issue.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294317: Insufficient build rules for tzdb.dat

Reviewers

• Joe Wang (@JoeWang-Java - Reviewer) ⚠️ Review applies to 8e260f28
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10415/head:pull/10415
$ git checkout pull/10415

Update a local copy of the PR:
$ git checkout pull/10415
$ git pull https://git.openjdk.org/jdk pull/10415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10415

View PR using the GUI difftool:
$ git pr show -t 10415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10415.diff

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a1687575)
• 00: Full (8e260f28)

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294317: Insufficient build rules for tzdb.dat

Reviewed-by: joehw, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• 1f521a1: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows
• 5ae6bc2: 8234262: Unmask SIGQUIT in a child process
• 968af74: 8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate the marker
• 36b61c5: 8293872: Make runtime/Thread/ThreadCountLimit.java more robust
• 2be3158: 4797982: Setting negative size of JSplitPane divider leads to unexpected results.
• 050eebf: 8294245: Make Compile::print_inlining_stream stack allocated
• 91a23d7: 8294142: make test should report only on executed tests
• 169a5d4: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory
• 3675f4c: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics
• 543851d: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume
• ... and 70 more: https://git.openjdk.org/jdk/compare/4020ed53dd6e45cafa1d86432274700f0d4a67ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

Have you verified that this works? I would expect a wildcard call to be needed.

Suggested change

	TZDATA_TZFILES := $(TZDATA_DIR)/*
	TZDATA_TZFILES := $(wildcard $(TZDATA_DIR)/*)

[naotoj]

I confirmed the fix worked, on my local mac and mach5. However, your suggestion does seem the right way. Modified the fix as suggested.

[erikj79]

Hm, yes, I think there are some cases where wildcards will be resolved without a call to wildcard. I'm also not sure that kind of expansion works the same across make versions, and if you ever needed to use that file list for anything else, it would be easy to trip up. I think this was expanded in the rule evaluation itself, not in the assignment. By being explicit with the call, we know what we are getting.

[naotoj]

/integrate

[openjdk]

Going to push as commit 7151128.
Since your change was applied there have been 96 commits pushed to the master branch:

• fb4979c: 8290401: Support dump all phases and print nodes in ascending order of index
• 112ca2b: 8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest
• 99017b0: 8293064: Remove unused NET_xxx functions
• 3419363: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl
• 1abf971: 8249627: Degrade Thread.suspend and Thread.resume
• bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
• dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• 14c6ac4: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 02ea338: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
• 49a7347: 8294408: Problemlist runtime/handshake/HandshakeSuspendExitTest.java
• ... and 86 more: https://git.openjdk.org/jdk/compare/4020ed53dd6e45cafa1d86432274700f0d4a67ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit 7151128.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.