8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest

[matias9927]

The check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest was removed due to it being unused. Ran tier1 to verify. Please review

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer) ⚠️ Review applies to 88a106fb
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10425/head:pull/10425
$ git checkout pull/10425

Update a local copy of the PR:
$ git checkout pull/10425
$ git pull https://git.openjdk.org/jdk pull/10425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10425

View PR using the GUI difftool:
$ git pr show -t 10425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10425.diff

[bridgekeeper]

👋 Welcome back matias9927! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (95167efa)
• 00: Full (88a106fb)

[calvinccheung]

Looks good. Thanks.

[openjdk]

⚠️ @matias9927 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8293964_checkForDuplicates
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest

Reviewed-by: ccheung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 3419363: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl
• 1abf971: 8249627: Degrade Thread.suspend and Thread.resume
• bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
• dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• 14c6ac4: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 02ea338: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
• 49a7347: 8294408: Problemlist runtime/handshake/HandshakeSuspendExitTest.java
• aa48705: 8289422: Fix and re-enable vector conditional move
• 1ddc92f: 8294404: [BACKOUT] JDK-8294142: make test should report only executed tests
• 1e222bc: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image
• ... and 12 more: https://git.openjdk.org/jdk/compare/543851db926469df57a8f4a2bd3458349012145f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@calvinccheung, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

Looks good. Thanks.

[matias9927]

/integrate

[openjdk]

@matias9927
Your change (at version 95167ef) is now ready to be sponsored by a Committer.

[calvinccheung]

/sponsor

[openjdk]

Going to push as commit 112ca2b.
Since your change was applied there have been 23 commits pushed to the master branch:

• 99017b0: 8293064: Remove unused NET_xxx functions
• 3419363: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl
• 1abf971: 8249627: Degrade Thread.suspend and Thread.resume
• bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
• dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• 14c6ac4: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 02ea338: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
• 49a7347: 8294408: Problemlist runtime/handshake/HandshakeSuspendExitTest.java
• aa48705: 8289422: Fix and re-enable vector conditional move
• 1ddc92f: 8294404: [BACKOUT] JDK-8294142: make test should report only executed tests
• ... and 13 more: https://git.openjdk.org/jdk/compare/543851db926469df57a8f4a2bd3458349012145f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung @matias9927 Pushed as commit 112ca2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.