8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow #10427

AlanBateman · 2022-09-26T15:35:28Z

BlockingChannelOps.java and BlockingSocketOps.java test virtual threads doing blocking I/O on channels and java.net sockets.

BlockingChannelOps has 32 tests at this time and takes nearly 120s to run due to several tests that sleep to improve the chances that threads are blocked. These sleeps can be replaced with a poll of the thread state so the test runs in 3-4s. BlockingSocketOps has be changed to do the same time.

In passing, I updated the tests in BlockingSocketOps that bound a ServerSocket to the wildcard address so they bind to the loopback address instead. This helps reduce potential interference in CI environments. I also put a workaround into BlockingChannelOps for macOS where the kernel appears to increase the amount of bytes that can be buffered in the socket sender buffer, it's otherwise too hard to test that socket writes block on that platform.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow

Reviewers

Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10427/head:pull/10427
$ git checkout pull/10427

Update a local copy of the PR:
$ git checkout pull/10427
$ git pull https://git.openjdk.org/jdk pull/10427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10427

View PR using the GUI difftool:
$ git pr show -t 10427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10427.diff

bridgekeeper · 2022-09-26T15:44:34Z

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-26T15:48:57Z

@AlanBateman The following labels will be automatically applied to this pull request:

net
nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-26T16:13:01Z

Webrevs

test/jdk/java/nio/channels/vthread/BlockingChannelOps.java

jaikiran · 2022-09-27T12:17:15Z

test/jdk/java/nio/channels/vthread/BlockingChannelOps.java

-                // schedule write
-                ByteBuffer bb = ByteBuffer.wrap("XXX".getBytes("UTF-8"));
-                ScheduledWriter.schedule(sink, bb, DELAY);
+                // delaye write from sink


Minor typo - delaye instead of delayed

dfuch · 2022-09-27T13:35:41Z

test/jdk/java/net/vthread/BlockingSocketOps.java

-        }
-        static void schedule(Closeable c, long delay) {
-            new Thread(new ScheduledCloser(c, delay)).start();
+    static void readToEOF(InputStream in) throws IOException {


just curious: isn't that just in.readAllBytes()?
Oh - I see. You don't want to accumulate all the bytes.
An alternative would be in.transferTo(OutputStream.nullOutputStream())

Or perhaps InputStream.skip(MAX_INT).

Yes, transferTo would work too. We just need something to read the input stream to EOF so that the connection peer reads -1/EOF.

test/jdk/java/net/vthread/BlockingSocketOps.java

jaikiran · 2022-09-28T09:45:39Z

BlockingChannelOps has 32 tests at this time and takes nearly 120s to run due to several tests that sleep to improve the chances that threads are blocked. These sleeps can be replaced with a poll of the thread state so the test runs in 3-4s. BlockingSocketOps has be changed to do the same time.

That's a really good improvement on the testing time. I gave this PR a try on my local Mac setup and as you note, each @run of the test now completes between 2 to 4 seconds for me.

Now that these tests complete fast, do you think we should now remove all the /timeout=300 from each of the test definitions?

AlanBateman · 2022-09-28T09:57:22Z

Now that these tests complete fast, do you think we should now remove all the /timeout=300 from each of the test definitions?

I'll have to check. The reason for /timeout on some of these tests is because most of the testing has been with debug builds rather than release builds.

jaikiran

Thank you for those changes. The current state of this PR looks fine to me.

openjdk · 2022-09-28T12:02:52Z

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
ea61671: 8294359: Interpreter(AArch64) intrinsify Thread.currentThread()
c42ef70: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
94e14da: 8294057: Parallel: Tighten ParallelCompactData::initialize_region_data
1ea0d6b: 8292301: [REDO v2] C2 crash when allocating array of size too large
c13e0ef: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7
79ccc79: 8293613: need to properly handle and hide tmp VTMS transitions
5e1e449: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
d827fd8: 8294430: RISC-V: Small refactoring for movptr_with_offset
9d76ac8: 8292158: AES-CTR cipher state corruption with AVX-512
... and 12 more: https://git.openjdk.org/jdk/compare/1abf971b93222f422c0026cee944a6db214f955a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

AlanBateman · 2022-09-28T13:08:08Z

/integrate

openjdk · 2022-09-28T13:10:54Z

Going to push as commit 37f83b9.
Since your change was applied there have been 22 commits pushed to the master branch:

60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
ea61671: 8294359: Interpreter(AArch64) intrinsify Thread.currentThread()
c42ef70: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
94e14da: 8294057: Parallel: Tighten ParallelCompactData::initialize_region_data
1ea0d6b: 8292301: [REDO v2] C2 crash when allocating array of size too large
c13e0ef: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7
79ccc79: 8293613: need to properly handle and hide tmp VTMS transitions
5e1e449: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
d827fd8: 8294430: RISC-V: Small refactoring for movptr_with_offset
9d76ac8: 8292158: AES-CTR cipher state corruption with AVX-512
... and 12 more: https://git.openjdk.org/jdk/compare/1abf971b93222f422c0026cee944a6db214f955a...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-28T13:11:14Z

@AlanBateman Pushed as commit 37f83b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Initial commit

a1a23d1

openjdk bot added nio nio-dev@openjdk.org net net-dev@openjdk.org labels Sep 26, 2022

AlanBateman marked this pull request as ready for review September 26, 2022 16:06

openjdk bot added the rfr Pull request is ready for review label Sep 26, 2022

jaikiran reviewed Sep 27, 2022

View reviewed changes

test/jdk/java/nio/channels/vthread/BlockingChannelOps.java Show resolved Hide resolved

jaikiran reviewed Sep 27, 2022

View reviewed changes

test/jdk/java/nio/channels/vthread/BlockingChannelOps.java Show resolved Hide resolved

jaikiran reviewed Sep 27, 2022

View reviewed changes

dfuch reviewed Sep 27, 2022

View reviewed changes

AlanBateman added 2 commits September 27, 2022 16:07

Merge

477fc36

Change testSocketWrite1 to use in.transfer, and fix typo in comment

54da8de

jaikiran reviewed Sep 28, 2022

View reviewed changes

test/jdk/java/net/vthread/BlockingSocketOps.java Outdated Show resolved Hide resolved

Drop /timeout from run tags. Fix out of date comment

7097193

jaikiran approved these changes Sep 28, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2022

openjdk bot added the integrated Pull request has been integrated label Sep 28, 2022

openjdk bot closed this Sep 28, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow #10427

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow #10427

AlanBateman commented Sep 26, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 26, 2022

openjdk bot commented Sep 26, 2022

mlbridge bot commented Sep 26, 2022 •

edited

Loading

jaikiran Sep 27, 2022

dfuch Sep 27, 2022

RogerRiggs Sep 27, 2022

AlanBateman Sep 27, 2022 •

edited

Loading

jaikiran commented Sep 28, 2022

AlanBateman commented Sep 28, 2022

jaikiran left a comment

openjdk bot commented Sep 28, 2022

AlanBateman commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow #10427

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow #10427

Conversation

AlanBateman commented Sep 26, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 26, 2022

openjdk bot commented Sep 26, 2022

mlbridge bot commented Sep 26, 2022 • edited Loading

Webrevs

jaikiran Sep 27, 2022

Choose a reason for hiding this comment

dfuch Sep 27, 2022

Choose a reason for hiding this comment

RogerRiggs Sep 27, 2022

Choose a reason for hiding this comment

AlanBateman Sep 27, 2022 • edited Loading

Choose a reason for hiding this comment

jaikiran commented Sep 28, 2022

AlanBateman commented Sep 28, 2022

jaikiran left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 28, 2022

AlanBateman commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

AlanBateman commented Sep 26, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 26, 2022 •

edited

Loading

AlanBateman Sep 27, 2022 •

edited

Loading