Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294472: Remove redundant rawtypes suppression in AbstractChronology #10433

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 26, 2022

Found this redundant suppressions by IntelliJ IDEA inspection.
Seems initially Chronology was generic class?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294472: Remove redundant rawtypes suppression in AbstractChronology

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10433/head:pull/10433
$ git checkout pull/10433

Update a local copy of the PR:
$ git checkout pull/10433
$ git pull https://git.openjdk.org/jdk pull/10433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10433

View PR using the GUI difftool:
$ git pr show -t 10433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10433.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@turbanoff The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Sep 26, 2022
@turbanoff turbanoff changed the title [PATCH] Remove redundant rawtypes suppression in AbstractChronology 8294472: Remove redundant rawtypes suppression in AbstractChronology Sep 27, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294472: Remove redundant rawtypes suppression in AbstractChronology

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 739fdec: 8289162: runtime/NMT/ThreadedMallocTestType.java should print out memory allocations to help debug
  • a11477c: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
  • 7151128: 8294317: Insufficient build rules for tzdb.dat
  • fb4979c: 8290401: Support dump all phases and print nodes in ascending order of index
  • 112ca2b: 8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest
  • 99017b0: 8293064: Remove unused NET_xxx functions
  • 3419363: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl
  • 1abf971: 8249627: Degrade Thread.suspend and Thread.resume
  • bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
  • dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • ... and 9 more: https://git.openjdk.org/jdk/compare/1f521a12041b33b3458f952627d535fad6e928c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 27, 2022
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2022

Going to push as commit 9309786.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
  • 4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
  • 7515b30: 8279283: BufferedInputStream should override transferTo
  • 7401fe0: 8292912: Make guard card in CardTable inaccessible
  • 70d8428: 8294520: Problemlist java/nio/file/Files/CopyProcFile.java
  • 30e3bf9: 8291805: IGV: Improve Zooming
  • 37f83b9: 8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow
  • 60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
  • ea61671: 8294359: Interpreter(AArch64) intrinsify Thread.currentThread()
  • c42ef70: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
  • ... and 31 more: https://git.openjdk.org/jdk/compare/1f521a12041b33b3458f952627d535fad6e928c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2022
@openjdk openjdk bot closed this Sep 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2022
@openjdk
Copy link

openjdk bot commented Sep 28, 2022

@turbanoff Pushed as commit 9309786.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_rawtypes_suppression_AbstractChronology branch October 27, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants