8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

[plummercj]

Sometimes SA fails to startup with the following error message:

ERROR: failed to workaround classshareing
Unable to open core file

The code in question is init_classsharing_workaround() in ps_core_common.c. There a number of reasons why the class sharing work around can fail, and the reason is usually pretty well described with a print_debug() statement. However, since this is an error, these should really just be print_error() statements so the user doesn't need to figure out how to get more info by setting LIBSAPROC_DEBUG (which may also produce a ton of output unrelated to the error).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

Reviewers

• Kevin Walls (@kevinjwalls - Committer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10438/head:pull/10438
$ git checkout pull/10438

Update a local copy of the PR:
$ git checkout pull/10438
$ git pull https://git.openjdk.org/jdk pull/10438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10438

View PR using the GUI difftool:
$ git pr show -t 10438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10438.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3bc3e9e3)

[kevinjwalls]

Very useful!

[sspitsyn]

Looks good.
Thanks,
Serguei

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 5e1e449: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
• d827fd8: 8294430: RISC-V: Small refactoring for movptr_with_offset
• 9d76ac8: 8292158: AES-CTR cipher state corruption with AVX-512
• e5b65c4: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications
• f8d9fa8: 8294483: Remove vmTestbase/nsk/jvmti/GetThreadState tests.
• 6ad151d: 8293143: Workaround for JDK-8292217 when doing "step over" of bytecode with unresolved cp reference
• 22b59b6: 8294471: SpecTaglet is inconsistent with SpecTree for inline property
• 763d4bf: 8293592: Remove JVM_StopThread, stillborn, and related cleanup
• 739fdec: 8289162: runtime/NMT/ThreadedMallocTestType.java should print out memory allocations to help debug
• a11477c: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
• ... and 24 more: https://git.openjdk.org/jdk/compare/169a5d48afbc6627f36a768c17c2a5e56219d9c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks, Kevin and Serguei!

/integrate

[openjdk]

Going to push as commit 3b7fc80.
Since your change was applied there have been 47 commits pushed to the master branch:

• 4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
• 7515b30: 8279283: BufferedInputStream should override transferTo
• 7401fe0: 8292912: Make guard card in CardTable inaccessible
• 70d8428: 8294520: Problemlist java/nio/file/Files/CopyProcFile.java
• 30e3bf9: 8291805: IGV: Improve Zooming
• 37f83b9: 8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow
• 60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
• ea61671: 8294359: Interpreter(AArch64) intrinsify Thread.currentThread()
• c42ef70: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
• 94e14da: 8294057: Parallel: Tighten ParallelCompactData::initialize_region_data
• ... and 37 more: https://git.openjdk.org/jdk/compare/169a5d48afbc6627f36a768c17c2a5e56219d9c7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 3b7fc80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.