8294430: RISC-V: Small refactoring for movptr_with_offset

[RealFYang]

The name of function 'movptr_with_offset' looks misleading. It actually returns an offset to its caller.
We could rename this function to 'movptr' so that it overloads existing function 'movptr'.

   void movptr(Register Rd, address addr);
- void movptr_with_offset(Register Rd, address addr, int32_t &offset);
+ void movptr(Register Rd, address addr, int32_t &offset);

Testing: Tier1 hotspot on HiFive Linux-riscv64 Unmatched board.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294430: RISC-V: Small refactoring for movptr_with_offset

Reviewers

• Feilong Jiang (@feilongjiang - Author)
• Yadong Wang (@yadongw - Author)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10439/head:pull/10439
$ git checkout pull/10439

Update a local copy of the PR:
$ git checkout pull/10439
$ git pull https://git.openjdk.org/jdk pull/10439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10439

View PR using the GUI difftool:
$ git pr show -t 10439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10439.diff

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (05586f7f)

[feilongjiang]

Looks fine, thanks!

[yadongw]

lgtm

[shipilev]

Looks fine.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294430: RISC-V: Small refactoring for movptr_with_offset

Reviewed-by: fjiang, yadongwang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• 14c6ac4: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 02ea338: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
• 49a7347: 8294408: Problemlist runtime/handshake/HandshakeSuspendExitTest.java
• aa48705: 8289422: Fix and re-enable vector conditional move
• 1ddc92f: 8294404: [BACKOUT] JDK-8294142: make test should report only executed tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

@ALL: Thanks for the review.
/integrate

[openjdk]

Going to push as commit d827fd8.
Since your change was applied there have been 21 commits pushed to the master branch:

• 9d76ac8: 8292158: AES-CTR cipher state corruption with AVX-512
• e5b65c4: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications
• f8d9fa8: 8294483: Remove vmTestbase/nsk/jvmti/GetThreadState tests.
• 6ad151d: 8293143: Workaround for JDK-8292217 when doing "step over" of bytecode with unresolved cp reference
• 22b59b6: 8294471: SpecTaglet is inconsistent with SpecTree for inline property
• 763d4bf: 8293592: Remove JVM_StopThread, stillborn, and related cleanup
• 739fdec: 8289162: runtime/NMT/ThreadedMallocTestType.java should print out memory allocations to help debug
• a11477c: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
• 7151128: 8294317: Insufficient build rules for tzdb.dat
• fb4979c: 8290401: Support dump all phases and print nodes in ascending order of index
• ... and 11 more: https://git.openjdk.org/jdk/compare/1e222bccd3807c1be0d1d824e0ff9745751d8375...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit d827fd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.